Skip to content

Symfony 8 support#579

Merged
irfan-dahir merged 3 commits into5.0.0from
symfony-8-support
Jan 18, 2026
Merged

Symfony 8 support#579
irfan-dahir merged 3 commits into5.0.0from
symfony-8-support

Conversation

@irfan-dahir
Copy link
Copy Markdown
Collaborator

  • Symfony 7.4+, 8+ uses PHP's native html5 parser
  • MAL's HTML when it comes to tables doesn't follow HTML semantically, so there's no tbody element.
  • The native HTML5 parser inserts that into the DOM
  • So previous selectors like //table[contains(@class, "entries-table")]/tr do not work and require tbody in there '//table[contains(@class, "entries-table")]/tbody/tr
  • Most of the changes were in this apart from a few

Fixes: #575 #574

New underlying html5 native parser used in symfony 7.4+ was causing the parser to break during table filters. This is due to the new parser inserting a `tbody` node when there's non present.
Bump PHP version from 8.2/8.3 to 8.4 in code quality and test workflows to ensure compatibility and test coverage with the latest PHP release.
@irfan-dahir irfan-dahir merged commit a344c18 into 5.0.0 Jan 18, 2026
3 checks passed
@irfan-dahir irfan-dahir deleted the symfony-8-support branch January 18, 2026 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant