fix: guard invalid unicode queue payloads#15576
Open
harsh21234i wants to merge 2 commits intokestra-io:developfrom
Open
fix: guard invalid unicode queue payloads#15576harsh21234i wants to merge 2 commits intokestra-io:developfrom
harsh21234i wants to merge 2 commits intokestra-io:developfrom
Conversation
# Conflicts: # jdbc-postgres/src/test/java/io/kestra/runner/postgres/PostgresQueueTest.java
2aee528 to
04b94da
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey @loicmathieu
Summary
Updates the fix for invalid Unicode payload handling so malformed Unicode
does not still destabilize the instance.
This follows up on the reopened
#14806report that the issue was stillreproducible and could still kill the instance.
What changed
DefaultLogEntryEmitteragainst unsupported queue payloads soinvalid log entries are dropped instead of letting the async queue failure
bubble out
JdbcQueueClientso lonesurrogate / invalid Unicode payload failures are converted into
UnsupportedMessageExceptionwhen queue emission fails with
UnsupportedMessageExceptionWhy
The previous handling covered some invalid payload cases, but malformed
Unicode could still escape through log emission. That left a crash path
open even after the earlier fix.
Notes:
fully run the Postgres-backed test class in this environment because no
local PostgreSQL instance was available.
Related