feat: show modifier-only keypresses in visualizer#343
Open
quiet-node wants to merge 1 commit intokeycastr:mainfrom
Open
feat: show modifier-only keypresses in visualizer#343quiet-node wants to merge 1 commit intokeycastr:mainfrom
quiet-node wants to merge 1 commit intokeycastr:mainfrom
Conversation
Previously, pressing a modifier key alone (Command, Shift, Option, Control) produced no output. macOS fires kCGEventFlagsChanged for these, which was routed to noteFlagsChanged: but implemented as a no-op. Track previous modifier state and detect newly pressed modifiers on each flags-changed event. Build a glyph string and append it to the visualizer window. Respects Command-keys-only display mode. Signed-off-by: Logan Nguyen <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Pressing a modifier key alone (⌘, ⇧, ⌥, ⌃) showed nothing. Only combos like ⌘E worked.
This is because macOS fires
kCGEventFlagsChangedfor modifier-only presses instead ofkCGEventKeyDown. KeyCastr already captured these events butnoteFlagsChanged:was a no-op.Fix
Implement
noteFlagsChanged:to detect newly pressed modifiers and display their glyphs. Respects the existing "Command Keys Only" display mode.