Improvement - Removed exception catch on failed Event persistence #8567
artur-baltabayev
started this conversation in
Archive
Replies: 1 comment
-
|
Makes sense and doesn't need discussing since we've already discussed this for admin events. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
This was done before for admin events in the AdminEventBuilder.
The issue was that events did not trigger a transaction rollback due to the exception being handled and converted to a simple log message. We discovered that there is another such place in the code and would want to correct that aswell.
PR : #8568
Here is the previous pr for the admin events : #8166
Beta Was this translation helpful? Give feedback.
All reactions