Skip to content

KEYCLOAK-18470 Admin events trigger transaction rollback if exception is thrown#8166

Closed
artur-baltabayev wants to merge 1 commit intokeycloak:masterfrom
bosch-io:feature/KEYCLOAK-18740-Admin-event-exception-handling
Closed

KEYCLOAK-18470 Admin events trigger transaction rollback if exception is thrown#8166
artur-baltabayev wants to merge 1 commit intokeycloak:masterfrom
bosch-io:feature/KEYCLOAK-18740-Admin-event-exception-handling

Conversation

@artur-baltabayev
Copy link
Copy Markdown
Contributor

@artur-baltabayev artur-baltabayev commented Jun 15, 2021

No description provided.

@artur-baltabayev artur-baltabayev mentioned this pull request Jun 15, 2021
Closed
@hongquyen196
Copy link
Copy Markdown

hongquyen196 commented Aug 12, 2021

Hello @artur-baltabayev this topic I am interested in. When will the pull request merge?

@hongquyen196
Copy link
Copy Markdown

hongquyen196 commented Aug 12, 2021

It seems you linked it with the wrong Jira. Can you fix please? KEYCLOAK-17841 or KEYCLOAK-17524

@artur-baltabayev
Copy link
Copy Markdown
Contributor Author

artur-baltabayev commented Aug 12, 2021

@hongquyen196 Hello, thank you for the response ! It was decided to split the issue into two PR's. So this PR doesn't have a specific JIRA issue, but rather a parent issue (KEYCLOAK-17841).

@hongquyen196
Copy link
Copy Markdown

hongquyen196 commented Aug 13, 2021

@artur-baltabayev What about KEYCLOAK-18740?. I see it in this title.

@artur-baltabayev artur-baltabayev changed the title KEYCLOAK-18740 Admin events trigger transaction rollback if exception is thrown KEYCLOAK-18470 Admin events trigger transaction rollback if exception is thrown Aug 13, 2021
@artur-baltabayev
Copy link
Copy Markdown
Contributor Author

artur-baltabayev commented Aug 13, 2021 •
edited
Loading

@hongquyen196 You were correct ! The number is the title was was wrong (18740 should've been 18470) and there is in fact a Jira issue. Sorry about that. Here is the correct issue : https://issues.redhat.com/browse/KEYCLOAK-18470

@stianst stianst self-assigned this Sep 13, 2021
@stianst
Copy link
Copy Markdown
Contributor

stianst commented Sep 13, 2021

GitHub actions is not executing for some reason, so opened a new PR here #8424

@stianst stianst mentioned this pull request Sep 13, 2021
Merged
@stianst
Copy link
Copy Markdown
Contributor

stianst commented Sep 13, 2021

Merged in #8424

@stianst stianst closed this Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stianst stianst stianst approved these changes

+1 more reviewer

@hongquyen196 hongquyen196 hongquyen196 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@stianst stianst

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@artur-baltabayev @hongquyen196 @stianst