Conversation
|
LGTM |
|
One of the questions I had in one of the GitHub discussions was if and how you could pass SPI config via environment variables, and the answer was yes via |
|
Sounds good to me, but adding a hint for the env var format Additionally, perhaps an admonition or something similar to make clear, that just setting config values for a provider is done with runtime config and setting/enabling/disabling a provider is done at buildtime would make things more obviously to customers, as I already see confusion at users with the buildtime/runtime configs now used in Keycloak. |
|
@danielFesenmeyer @tanadeau The different configuration sources are covered in the Configuration Guide. Not sure if we should explain here how to use env vars. Would make sense to include a link to the configuration guide in the |
@dasniko I tried to make it obvious by providing examples using the appropriate command as well as a bit of text explaining the reason. But if you are asking is because it is not yet clear. Do you have any suggestions on how to make this clear? |
Co-authored-by: Stian Thorgersen <[email protected]> Closes keycloak#10400
d34b93e to
1298f33
Compare
@pedroigor For me, it's clear. But I notice some difficutlies for users in other forums to cope with now buildtime and runtime configs, as this is a new approach. Nothing special for the SPI config, but general config approach. Even when using the new config guide, people don't see that there are build and run configs. Sad, but true. |
|
@dasniko Yes, you are right. And we are trying since the beginning to make the build/runtime concepts less painful. Not an easy task, but I hope we can continuously improve the UX and make the |
|
@pedroigor, just adding an environment example with the example you already have would be very helpful. |
I see. As I mentioned before, I would like to avoid duplicating information in guides. We kinda have that covered in the configuration guide. Formatting options to their corresponding env format should be trivial if you read that guide? |
Closes #10400