Conversation
There was a problem hiding this comment.
Nice, thanks! PR itself LGTM (assuming the tests are green) - but could you also change the https://www.keycloak.org/server/hostname guide pls to reflect these changes?
edit: seems there are also regressions to the operator testsuite.
46182ff to
901963f
Compare
|
@DGuhr Updated the guide. |
901963f to
239a542
Compare
|
@pedroigor sorry, forgot to mention the proxy guide. when |
239a542 to
e459a0b
Compare
|
@pedroigor think i spotted a bug, iirc the behaviour was different before: scenario: run start-dev with https. want to access admin login after creating initial admin user.
outcome: invalid redirect_uri, see screenshot. also it now opens with id.keycloak.test instead of localhost. expected behaviour: login page for master realm opens with uri localhost:8555, as Would be nice if we could check these also using automated tests (like assertAdminPage in the old testsuite), e.g. https://www.testcontainers.org/modules/webdriver_containers/ or using RestAssured. |
|
@DGuhr Not really a bug because the client is not configured to allow that redirect URI. Try accessing using the hostname and it should work. |
e459a0b to
81da818
Compare
|
@pedroigor uh yes, absolutely right, my apologies. So then LGTM here :) Not 100% sure we would not need a |
bb78148 to
88259e0
Compare
Closes keycloak#10627 Closes keycloak#10331
DGuhr
left a comment
There was a problem hiding this comment.
seen tests working on https://github.com/andreaTP/keycloak/runs/5630710431?check_suite_focus=true so lgtm :)
02f506e to
6dde620
Compare
|
I'm having troubles having the admin GUI behind a proxy since 17.0.1. I'm not sure if it would be caused by this issue and if it is an issue or a feature. Should I be configuring something differently now? |
|
@pedroigor I was using the What is the recommended migration for this scenario? edit: changing |
|
@AllexVeldman Now the admin URLs are solely based on the request info. That also means obtaining the info from the HTTP headers forwarded by your proxy. |
|
@pedroigor The redirect_url is correctly built, it's the request for the login form that does not accept the redirect_uri: with keycloak.conf So my flow is
|
|
I got it to work by setting the frontendUrl of the master domain as suggested in https://keycloak.discourse.group/t/frontendurl-and-adminurl-how-to-restrict-admin-console-to-internal-ip-only/2655 |
|
+1. It should also be possible to register the |
nonevalue for theproxyoption. Users should not really set this value but don't setproxy. It also causes issues when resolvingkc.proxybecause ifnoneis set, the resolved value isnoneand notfalse.hostname-portoption to allow setting the port the proxy is using to expose the frontend URL.hostname-adminoption because it is causing a lot of unnecessary confusion. We instead default to using the request info (scheme, port, etc) to build the admin Url and rely on the proxy to expose or not this URL.Closes #10627
Closes #10331