Include 'urn:ietf:params:oauth:grant-type:token-exchange' in grant_ty…#10904
Merged
pedroigor merged 1 commit intokeycloak:mainfrom Jun 30, 2022
Merged
Conversation
…pes_supported field of Keycloak OP metadata, if token-exchange is enabled closes keycloak#10888
DGuhr
approved these changes
Mar 24, 2022
Contributor
DGuhr
left a comment
There was a problem hiding this comment.
LGTM :) thanks.
one could think about using a different List GRANT_TYPES_SUPPORTED in addition to DEFAULT_GRANT_TYPES_SUPPORTED, as the default list now can also contain non-default entries depending on the feature. Then adding the optional grant type for token exchange to that list instead and use that list later on. but not blocking the PR imo.
Contributor
Author
|
Changing the list name is not a problem. I agree that GRANT_TYPES_SUPPORTED may be better name. Is anything else blocking accepting this issue? Or you plan to make Token Exchange a default feature in Keycloak 19? If you do this, 'urn:ietf:params:oauth:grant-type:token-exchange' must be added to DEFAULT_GRANT_TYPES_SUPPORTED list. |
DGuhr
approved these changes
Jun 29, 2022
pedroigor
approved these changes
Jun 30, 2022
Contributor
|
@cgeorgilakis Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…pes_supported field of Keycloak OP metadata, if token-exchange is enabled
closes #10888