Merged
Conversation
vmuzikar
requested changes
Mar 28, 2022
Contributor
vmuzikar
left a comment
There was a problem hiding this comment.
We should probably add some test for the fixed NPEs.
Contributor
Author
|
@vmuzikar would you like to indicate an already available test that I can expand to cover those cases? |
Contributor
Author
|
@vmuzikar added a test in ExportImportTest.java let see if the CI is happy 🙂 |
44bb6c0 to
ea55106
Compare
mposolda
requested changes
Mar 29, 2022
Contributor
Author
|
@mposolda addressed your comment and squashed commits. Ready for another check. |
mposolda
approved these changes
Mar 29, 2022
vmuzikar
approved these changes
Mar 29, 2022
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #10961