Add javadoc artefacts to spring bundles#10261
Merged
stianst merged 1 commit intokeycloak:mainfrom Feb 17, 2022
Merged
Conversation
pedroigor
approved these changes
Feb 16, 2022
abstractj
approved these changes
Feb 16, 2022
eucleciojosias
pushed a commit
to eucleciojosias/keycloak
that referenced
this pull request
Apr 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is only a partial solution as it only contains javadoc for adapter-core, and not for everything. However, including javadocs for all shaded dependencies is not working as it's causing a lot of missing classes, etc.
We do require at least something in the javadoc to be able to deploy the release to Sonatype OSSRH, and this is sufficient to unblock releases.
Closes #10260