Fixing responses when unexpected errors occurs#10383
Merged
stianst merged 1 commit intokeycloak:mainfrom Feb 23, 2022
Merged
Conversation
jkroepke
reviewed
Feb 22, 2022
Contributor
There was a problem hiding this comment.
Suggested change
| response.write(Buffer.buffer("")); | |
| response.write(Buffer.buffer("")); | |
| response.end(); |
Make it sense to end the requests here? I guess that should prevent any additional writes on the request.
Contributor
Author
There was a problem hiding this comment.
I tried that and it seems unnecessary because that is done later by vert.x itself.
45f78c1 to
743e860
Compare
DGuhr
previously approved these changes
Feb 22, 2022
743e860 to
273e25b
Compare
Contributor
Author
|
@DGuhr I'm updating the PR with a fix to the new tests to make it pass for Wildfly. Sorry, I had to dismiss your review. |
DGuhr
approved these changes
Feb 22, 2022
stianst
approved these changes
Feb 23, 2022
pedroigor
added a commit
to pedroigor/keycloak
that referenced
this pull request
Mar 21, 2022
stianst
pushed a commit
that referenced
this pull request
Mar 21, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #10338