Skip to content

json device code flow error responses#11462

Merged
mposolda merged 1 commit intokeycloak:mainfrom
eosc-kc:RCIAM-959-devicecodeflow-errors
Jun 29, 2022
Merged

json device code flow error responses#11462
mposolda merged 1 commit intokeycloak:mainfrom
eosc-kc:RCIAM-959-devicecodeflow-errors

Conversation

@cgeorgilakis
Copy link
Copy Markdown
Contributor

closes #11438

@mposolda mposolda self-assigned this Jun 27, 2022
Copy link
Copy Markdown
Contributor

@mposolda mposolda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cgeorgilakis Thanks for the PR. Can you please also add the test for this? Possibly new test method (or change of some existing test method) in the OAuth2DeviceAuthorizationGrantTest ?

@cgeorgilakis cgeorgilakis force-pushed the RCIAM-959-devicecodeflow-errors branch from bfedcdf to 34d59bc Compare June 28, 2022 08:01
@cgeorgilakis cgeorgilakis force-pushed the RCIAM-959-devicecodeflow-errors branch from 00ca8b1 to 6e1bd33 Compare June 28, 2022 10:48
@cgeorgilakis
Copy link
Copy Markdown
Contributor Author

I have added extra test methods in OAuth2DeviceAuthorizationGrantTest.
I want to mention that if rest api does not return json, oauth.doDeviceAuthorizationRequest will throw an exception.

@cgeorgilakis cgeorgilakis requested a review from mposolda June 28, 2022 11:56
Copy link
Copy Markdown
Contributor

@mposolda mposolda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cgeorgilakis Thanks!

@mposolda mposolda merged commit ccc0449 into keycloak:main Jun 29, 2022
@cgeorgilakis cgeorgilakis deleted the RCIAM-959-devicecodeflow-errors branch May 30, 2023 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix Device Authorization Grant error responses returned as HTML instead of JSON

2 participants