Fixes wrong encoding in container image#11547
Merged
stianst merged 1 commit intokeycloak:mainfrom Apr 22, 2022
Merged
Conversation
Contributor
Author
|
@stianst @pedroigor if you haven't started the release process for 18, i suggest to put this in beforehand. Talking to @jsorah they couldn't find immediate problems, but I'd want to avoid weird debugging sessions for locale-related edge cases in the future ;) |
Contributor
|
jFTR – apparently this was the solution for the original WF container. |
andreaTP
reviewed
Apr 21, 2022
29d01b2 to
9445c2a
Compare
andreaTP
previously approved these changes
Apr 21, 2022
jsorah
reviewed
Apr 21, 2022
a79146f to
8cdfbfe
Compare
andreaTP
previously approved these changes
Apr 21, 2022
8cdfbfe to
83155d0
Compare
stianst
reviewed
Apr 22, 2022
stianst
reviewed
Apr 22, 2022
Closes keycloak#11545 Co-authored-by: Joshua Sorah <[email protected]>
83155d0 to
7a4329d
Compare
stianst
approved these changes
Apr 22, 2022
DGuhr
added a commit
to DGuhr/keycloak
that referenced
this pull request
Jun 7, 2022
Closes keycloak#11545 Co-authored-by: Joshua Sorah <[email protected]> Co-authored-by: Joshua Sorah <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solution taken from https://access.redhat.com/solutions/5211991 -
would also work without thesedpart on line 22(tried locally), but I guess this makes sure all other stuff in the container also picks the right locale up.Tested building locally, and doing
docker run --rm -it --entrypoint bash kc_lang_test-> looked atlocaleoutput gave meen_US.UTF-8everywhere. Serverinfo now also shows right encoding.Closes #11545