Skip to content

Add again Client fields( Logo URL, Policy URL and Terms of service UR…#11837

Merged
ssilvert merged 1 commit intokeycloak:mainfrom
eosc-kc:11825_applicationpage
Aug 31, 2022
Merged

Add again Client fields( Logo URL, Policy URL and Terms of service UR…#11837
ssilvert merged 1 commit intokeycloak:mainfrom
eosc-kc:11825_applicationpage

Conversation

@cgeorgilakis
Copy link
Copy Markdown
Contributor

…L ) in ApplicationsPage.tsx of AccountConsole

Closes #11825

…L ) in ApplicationsPage.tsx of AccountConsole

Closes keycloak#11825
@ssilvert
Copy link
Copy Markdown
Contributor

@tyandor Can you take a look at this?

@cgeorgilakis
Copy link
Copy Markdown
Contributor Author

Kind reminder for checking this PR.
I remind you that these fields are showing in account console( Keycloan main branch) and a false PR merge remove them.

@stianst
Copy link
Copy Markdown
Contributor

stianst commented Aug 26, 2022

@ssilvert can someone from UI team review this one?

@cgeorgilakis
Copy link
Copy Markdown
Contributor Author

Any progress in reviewing it?
This functionality has been removed by false PR merged.

@ssilvert ssilvert merged commit a3f339a into keycloak:main Aug 31, 2022
@ThinkFactoryDigital
Copy link
Copy Markdown

As far as I see the content therefore comes from application.tsx and there is no one of this (tosUri, policyUri and logoUri included? {
"clientId": "test-client",
"clientName": "Test Application",
"description": "This is a test application",
"userConsentRequired": false,
"inUse": false,
"offlineAccess": false,
"rootUrl": "http://localhost/testclient",
"baseUrl": "",
"effectiveUrl": ""
},
{
"clientId": "account-console",
"clientName": "Account Console",
"userConsentRequired": false,
"inUse": true,
"offlineAccess": false,
"rootUrl": "${authBaseUrl}",
"baseUrl": "/realms/myrealm/account/",
"effectiveUrl": "http://localhost:8080/auth/realms/myrealm/account/"
},

Happend this because it was in keycloak.v2.account ... I tried to change the theme, but I do not get a logoUri??? Am I wrong or did n't I see something important?

@ThinkFactoryDigital
Copy link
Copy Markdown

Additional to the entry before:
image

@jonkoops
Copy link
Copy Markdown
Contributor

@crowmedia I would recommend you start a discussion, we generally do not look at closed issues with discussions on them.

@ThinkFactoryDigital
Copy link
Copy Markdown

Okay. sorry I did not recognize that it was closed. Thank you!

@cgeorgilakis
Copy link
Copy Markdown
Contributor Author

@crowmedia you must configure these attributes in admin console. By default clients does not have these values.
I do not know if any problem exists in new admin console. Our PR was firstly originated in old admin console.

@ThinkFactoryDigital
Copy link
Copy Markdown

@cgeorgilakis I did configure it in the admin console already. That's the reason, why I started to search, why it is not available in the account console. If it will be in the response, I can add it to my own theme.

Because of jonkoops hint I added it to a open discussion about the account console.

@ThinkFactoryDigital
Copy link
Copy Markdown

@cgeorgilakis I think I found out what you mean, but that was not the result I expected. I wanted to add a client logo to the list of my applications in the account console.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Client fields( Logo URL, Policy URL and Terms of service URL ) have been removed from ApplicationsPage.tsx in AccountConsole

5 participants