Adjust docs to reflect what was discussed in #11856#11872
Merged
pedroigor merged 2 commits intokeycloak:mainfrom May 16, 2022
Merged
Adjust docs to reflect what was discussed in #11856#11872pedroigor merged 2 commits intokeycloak:mainfrom
pedroigor merged 2 commits intokeycloak:mainfrom
Conversation
vmuzikar
reviewed
May 9, 2022
Contributor
vmuzikar
left a comment
There was a problem hiding this comment.
Maybe I'd also add a few words on how are hostname-strict-https and http-enabled related, more specifically why do we need to use hostname-strict-https=true despite having http-enabled=true.
pedroigor
reviewed
May 10, 2022
Co-authored-by: Pedro Igor <[email protected]>
pedroigor
approved these changes
May 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11579
cc @pedroigor @vmuzikar @andreaTP @andre-nascimento-rh @stianst - would love to get input and alignment on the other parts from #11856 w.r.t. making
http-enabledhidden and changingproxyto be a boolean value. (2b / 2c) but wanted to draft out the change as I am not 100% sure if that would suffice or we should add notes to other guides, e.g. deploying in production, reverse proxy, etc. Reverse proxy does not make much sense anymore right now, as what's stated there is wrong, but dependant on the decision on making proxy=true/false, this would lead to a rewrite nearly the whole guide, so I wanted to reach out first.