Allow permission configuration for username and email in user profile.#12620
Conversation
|
@ioemat Thanks. Those attributes do not allow setting permissions by design. IIRC, the changes are to allow changing the username but only if e-mail as the username is enabled? In the |
|
Thanks for the feedback @pedroigor, good point. I'll have a look into that. Just wanted to mention that it may take some time, since I'm currently busy with other things, but I it's still on my list. |
|
Hi @pedroigor, sorry for the long delay - I looked into the issue again, checked the changes and have a slightly different understanding:
Please correct me if I get something wrong or I'm overlooking something that should be considered. |
|
@ioemat I see. But why do you want to show the username in the admin console? It shouldn't change at all and it is properly handled internally. The changes to the account console make sense to me. |
Sorry @pedroigor I was not precise enough in my last comment: The change in the admin console is in the User Profile tab where attribute settings are configured. (Branch rebased to current main and additional test for verify profile page added) |
42b6ed8 to
7e53a9e
Compare
|
@ioemat This test is failing org.keycloak.testsuite.forms.VerifyProfileTest#testUsernameReadOnlyInProfile. Looks like the profile is fully updated so the current page is not expected (verify profile). This only happens if running all tests, running in isolation works fine. I think we can just set an attribute to the config to make sure the verify profile page is shown? Other than that, I run your version here and it looks great. One thing though. Can we take the opportunity to also support the If you can fix the test, I'll approve and merge. |
Enhanced Account API to respect access to these attributes. Resolves keycloak#12599
7e53a9e to
2a4e6f2
Compare
|
Thanks @pedroigor, I fixed the test (blame on me, I only tested it isolated ...) Regarding #13923 (that's the issue with required flag for email, right?) I suggest to do a follow-up PR. |
|
@ioemat Thanks for your patience :) |
Allow permission configuration for username and email in user profile configuration UI and enhance Account API to respect access to these attributes.
Resolves #12599