Unify expiration handling for SingleUseObjects#12230
Merged
hmlnarik merged 2 commits intokeycloak:mainfrom Jun 20, 2022
Merged
Conversation
Contributor
martin-kanis
left a comment
There was a problem hiding this comment.
Thanks @mhajas. I have one question.
Contributor
There was a problem hiding this comment.
Before, when expiration was not set, some providers used 0 as a default which meant the entity is expired. Now it is the exact opposite. Is this on purpose?
Contributor
Author
There was a problem hiding this comment.
Good point. However, the behaviour you described conflicts with Javadoc here. We should discuss this, I am adding discussion point to the meeting today.
dcfde80 to
e13d359
Compare
hmlnarik
reviewed
Jun 20, 2022
hmlnarik
reviewed
Jun 20, 2022
534d23b to
3ca0ef7
Compare
…eries automatically Closes keycloak#12563
This was referenced Jun 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #12205
Closes #12563