Skip to content

Hostname guide improvements#21846

Merged
vmuzikar merged 1 commit intokeycloak:mainfrom
Pepo48:issue-20931
Jul 28, 2023
Merged

Hostname guide improvements#21846
vmuzikar merged 1 commit intokeycloak:mainfrom
Pepo48:issue-20931

Conversation

@Pepo48
Copy link
Copy Markdown
Contributor

@Pepo48 Pepo48 commented Jul 20, 2023

  • changed hostname.adoc

Closes #20931

Supersedes #20973

@Pepo48 Pepo48 requested review from a team as code owners July 20, 2023 10:28
@ghost ghost added the team/cloud-native label Jul 20, 2023
@Pepo48 Pepo48 mentioned this pull request Jul 20, 2023
Closed
@vmuzikar vmuzikar requested review from mabartos and shawkins July 20, 2023 10:30
@vmuzikar vmuzikar self-assigned this Jul 20, 2023
@Pepo48
Copy link
Copy Markdown
Contributor Author

Pepo48 commented Jul 20, 2023 •
edited
Loading

Based on my quick research of the issues mentioned in the umbrella #14666, I observed 3 main areas, which stood out:

  • the proxy setup and options in general
  • misusage of the hostname-port configuration option
  • usage of HTTP (e.g. in a production mode)

Thus, in this PR I tried to clarify these more.

It's definitely up to a discussion, whether these topics should be described in more detail or even more topics should be covered. The feedback is therefore more than welcomed 😊

@vmuzikar vmuzikar requested a review from pedroigor July 20, 2023 12:03
shawkins
shawkins requested changes Jul 20, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@shawkins shawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor text edits. Otherwise it looks good.

Comment thread docs/guides/server/hostname.adoc Outdated
Comment thread docs/guides/server/hostname.adoc Outdated
@Pepo48
Copy link
Copy Markdown
Contributor Author

Pepo48 commented Jul 20, 2023

Just some minor text edits. Otherwise it looks good.

Suggestions applied. Thanks, @shawkins.

shawkins
shawkins reviewed Jul 20, 2023
View reviewed changes
Comment thread docs/guides/server/hostname.adoc Outdated
shawkins
shawkins approved these changes Jul 20, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@shawkins shawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just saw one more minor possible edit.

vmuzikar
vmuzikar reviewed Jul 25, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@vmuzikar vmuzikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Pepo48 Sorry for the late review. Nice improvements, thanks!

Comment thread docs/guides/server/hostname.adoc Outdated
Comment thread docs/guides/server/hostname.adoc Outdated
Comment thread docs/guides/server/hostname.adoc Outdated
vmuzikar
vmuzikar previously approved these changes Jul 26, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@vmuzikar vmuzikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Pepo48 LGTM, thanks.

@vmuzikar vmuzikar requested a review from shawkins July 26, 2023 14:45
shawkins
shawkins approved these changes Jul 27, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@shawkins shawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some additional minor editing suggestions.

Comment thread docs/guides/server/hostname.adoc Outdated
Comment thread docs/guides/server/hostname.adoc Outdated
@Pepo48 @vmuzikar
Hostname guide improvements
306b826 
* changed hostname.adoc

Closes keycloak#20931

Co-authored-by: Steven Hawkins <[email protected]>, Václav Muzikář <[email protected]>
Signed-off-by: Peter Zaoral <[email protected]>
@Pepo48
Copy link
Copy Markdown
Contributor Author

Pepo48 commented Jul 27, 2023

@shawkins @vmuzikar I applied the last suggestions, squashed the commits and rebased the branch.

@vmuzikar vmuzikar merged commit 8ad6bc4 into keycloak:main Jul 28, 2023
@vmuzikar
Copy link
Copy Markdown
Contributor

vmuzikar commented Jul 28, 2023

@Pepo48 Thanks!

Can you please prepare a backport?

@Pepo48 Pepo48 deleted the issue-20931 branch August 1, 2023 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shawkins shawkins shawkins approved these changes

@vmuzikar vmuzikar vmuzikar approved these changes

@mabartos mabartos Awaiting requested review from mabartos

@pedroigor pedroigor Awaiting requested review from pedroigor

Assignees

@vmuzikar vmuzikar

Labels

team/cloud-native

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Improvements on Documentation/Guides for "Hostname/Proxy/Admin Console" Settings

3 participants

@Pepo48 @vmuzikar @shawkins