Skip to content

added client side check for trivial password policies#32846

Merged
edewit merged 3 commits intokeycloak:mainfrom
edewit:issue-32845
Sep 12, 2024
Merged

added client side check for trivial password policies#32846
edewit merged 3 commits intokeycloak:mainfrom
edewit:issue-32845

Conversation

@edewit
Copy link
Copy Markdown
Contributor

@edewit edewit commented Sep 12, 2024

fixes: #32845

Signed-off-by: Erik Jan de Wit [email protected]

@edewit edewit requested review from a team as code owners September 12, 2024 08:15
@edewit edewit self-assigned this Sep 12, 2024
jonkoops
jonkoops suggested changes Sep 12, 2024
View reviewed changes
Comment thread themes/src/main/resources/theme/keycloak.v2/login/register.ftl Outdated
Comment thread themes/src/main/resources/theme/keycloak.v2/login/register.ftl Outdated
Comment thread themes/src/main/resources/theme/keycloak.v2/login/register.ftl Outdated
Comment thread themes/src/main/resources/theme/keycloak.v2/login/register.ftl Outdated
Comment thread themes/src/main/resources/theme/keycloak.v2/login/register.ftl Outdated
Comment thread themes/src/main/resources/theme/keycloak.v2/login/resources/js/password-policy.js
@keycloak-github-bot keycloak-github-bot Bot mentioned this pull request Sep 12, 2024
Closed
@keycloak-github-bot
Copy link
Copy Markdown

keycloak-github-bot Bot commented Sep 12, 2024

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.webauthn.registration.UserVerificationRegisterTest#discouragedNoVerification

Keycloak CI - WebAuthn IT (chrome)

java.lang.AssertionError: Expected RegisterPage but was Sign in to test (https://localhost:8543/auth/realms/test/protocol/openid-connect/auth?response_type=code&client_id=test-app&redirect_uri=https%3A%2F%2Flocalhost%3A8543%2Fauth%2Frealms%2Fmaster%2Fapp%2Fauth&state=0bfd9397-a9bf-4ee8-b37d-fce28412bc30&scope=openid)
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.keycloak.testsuite.pages.AbstractPage.assertCurrent(AbstractPage.java:47)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
...

Report flaky test

keycloak-github-bot[bot]
keycloak-github-bot Bot reviewed Sep 12, 2024
View reviewed changes
Copy link
Copy Markdown

@keycloak-github-bot keycloak-github-bot Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@edewit
changed to make use of template
8c00e3a 
Signed-off-by: Erik Jan de Wit <[email protected]>
@edewit edewit requested a review from jonkoops September 12, 2024 09:30
@edewit
nicer active policy structure
3bfc9f7 
Signed-off-by: Erik Jan de Wit <[email protected]>
jonkoops
jonkoops approved these changes Sep 12, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@jonkoops jonkoops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work!

This was referenced Sep 12, 2024
Closed
Closed
Closed
keycloak-github-bot[bot]
keycloak-github-bot Bot reviewed Sep 12, 2024
View reviewed changes
Copy link
Copy Markdown

@keycloak-github-bot keycloak-github-bot Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
Copy link
Copy Markdown

keycloak-github-bot Bot commented Sep 12, 2024

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.webauthn.registration.PubKeySignRegisterTest#publicKeySignaturesRSA

Keycloak CI - WebAuthn IT (chrome)

java.lang.AssertionError: Expected RegisterPage but was Sign in to test (https://localhost:8543/auth/realms/test/protocol/openid-connect/auth?response_type=code&client_id=test-app&redirect_uri=https%3A%2F%2Flocalhost%3A8543%2Fauth%2Frealms%2Fmaster%2Fapp%2Fauth&state=ebd2ef6e-e78c-42ba-a7a3-66004a094e25&scope=openid)
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.keycloak.testsuite.pages.AbstractPage.assertCurrent(AbstractPage.java:47)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
...

Report flaky test

org.keycloak.testsuite.forms.LevelOfAssuranceFlowTest#testWithOTPAndRecoveryCodesAtLevel2

Keycloak CI - Forms IT (chrome)

java.lang.AssertionError: Event expected
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.junit.Assert.assertNotNull(Assert.java:713)
	at org.keycloak.testsuite.AssertEvents.poll(AssertEvents.java:91)
...

Report flaky test

org.keycloak.testsuite.forms.MultipleTabsLoginTest#expiredAuthenticationAction_currentCodeExpiredExecution

Keycloak CI - Forms IT (chrome)

java.lang.AssertionError: Expected RegisterPage but was Sign in to test (https://localhost:8543/auth/realms/test/protocol/openid-connect/auth?response_type=code&client_id=test-app&redirect_uri=https%3A%2F%2Flocalhost%3A8543%2Fauth%2Frealms%2Fmaster%2Fapp%2Fauth&state=ea442c67-d8fc-420c-b350-51481f736a19&scope=openid)
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.keycloak.testsuite.pages.AbstractPage.assertCurrent(AbstractPage.java:47)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
...

Report flaky test

@edewit edewit merged commit 22f9d20 into keycloak:main Sep 12, 2024
@edewit edewit deleted the issue-32845 branch September 12, 2024 12:26
@edewit edewit mentioned this pull request Nov 20, 2024
Closed
@waynemorphic waynemorphic mentioned this pull request Nov 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@jonkoops jonkoops jonkoops approved these changes

@keycloak-github-bot keycloak-github-bot[bot] keycloak-github-bot[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@edewit edewit

Labels

flaky-test team/ui

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add client side password policy checks

2 participants

@edewit @jonkoops