fix: removing KeycloakApplication usage of keycloak-add-user.json by shawkins · Pull Request #39460 · keycloak/keycloak

shawkins · 2025-05-05T14:12:53Z

vmuzikar

Should we also get rid of the keycloak-add-user.json file in the testsuite? And mentions of it in POMs?

shawkins · 2025-05-06T15:38:39Z

Should we also get rid of the keycloak-add-user.json file in the testsuite? And mentions of it in POMs?

My understanding was that it was still being picked up for migration testing. I can certianly add a commit with it removed, just to double check.

vmuzikar · 2025-05-06T15:40:10Z

@shawkins It might be worth it, yes.

shawkins · 2025-05-06T17:37:42Z

@shawkins It might be worth it, yes.

I'm surprised, it seemed to work.

keycloak-github-bot

Unreported flaky test detected, please review

keycloak-github-bot · 2025-05-07T12:43:15Z

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.adapter.servlet.SAMLServletAdapterTest#multiTenant2SamlTest

Keycloak CI - Base IT

org.awaitility.core.ConditionTimeoutException: Assertion condition defined as a Lambda expression in org.keycloak.testsuite.util.URLAssert URL expected to begin with: https://localhost:8543/auth/realms/tenant2/login-action ; actual URL: https://localhost:8643/multi-tenant-saml/?realm=tenant2 within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
...

Report flaky test

mabartos

LGTM

keycloak-github-bot

Unreported flaky test detected, please review

keycloak-github-bot · 2025-05-07T13:30:56Z

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.adapter.servlet.SAMLServletAdapterTest#multiTenant2SamlTest

Keycloak CI - Base IT

org.awaitility.core.ConditionTimeoutException: Assertion condition defined as a Lambda expression in org.keycloak.testsuite.util.URLAssert URL expected to begin with: https://localhost:8543/auth/realms/tenant2/login-action ; actual URL: https://localhost:8643/multi-tenant-saml/?realm=tenant2 within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
...

Report flaky test

vmuzikar

@shawkins Thanks, LGTM.

keycloak-github-bot

Unreported flaky test detected, please review

keycloak-github-bot · 2025-05-07T15:59:03Z

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.adapter.servlet.SAMLServletAdapterTest#multiTenant2SamlTest

Keycloak CI - Base IT

org.awaitility.core.ConditionTimeoutException: Assertion condition defined as a Lambda expression in org.keycloak.testsuite.util.URLAssert URL expected to begin with: https://localhost:8543/auth/realms/tenant2/login-action ; actual URL: https://localhost:8643/multi-tenant-saml/?realm=tenant2 within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
...

Report flaky test

closes:keycloak#39428 Signed-off-by: Steve Hawkins <[email protected]>

Signed-off-by: Steve Hawkins <[email protected]>

keycloak-github-bot

Unreported flaky test detected, please review

keycloak-github-bot · 2025-05-08T07:58:14Z

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.cluster.SessionFailoverClusterTest#sessionFailover

Keycloak CI - Clustering IT

java.lang.RuntimeException: java.lang.IllegalStateException: Keycloak unexpectedly died :(
	at org.keycloak.testsuite.arquillian.containers.KeycloakQuarkusServerDeployableContainer.start(KeycloakQuarkusServerDeployableContainer.java:71)
	at org.jboss.arquillian.container.impl.ContainerImpl.start(ContainerImpl.java:185)
	at org.jboss.arquillian.container.impl.client.container.ContainerLifecycleController$8.perform(ContainerLifecycleController.java:137)
	at org.jboss.arquillian.container.impl.client.container.ContainerLifecycleController$8.perform(ContainerLifecycleController.java:133)
...

Report flaky test

…ycloak#39460) * fix: removing KeycloakApplication usage of keycloak-add-user.json closes:keycloak#39428 Signed-off-by: Steve Hawkins <[email protected]> * Removing the test keycloak-add-user.json Signed-off-by: Steve Hawkins <[email protected]> --------- Signed-off-by: Steve Hawkins <[email protected]>

shawkins force-pushed the iss39428 branch 3 times, most recently from c90ed12 to d4212a8 Compare May 5, 2025 17:33

keycloak-github-bot Bot added the flaky-test label May 5, 2025

keycloak-github-bot Bot mentioned this pull request May 5, 2025

Flaky test: org.keycloak.testsuite.webauthn.account.WebAuthnSigningInTest#setUpLinksTest #39347

Closed

shawkins force-pushed the iss39428 branch 2 times, most recently from f4c7d0d to ff5b4d9 Compare May 5, 2025 21:09

shawkins marked this pull request as ready for review May 6, 2025 11:55

shawkins requested review from a team as code owners May 6, 2025 11:55

keycloak-github-bot Bot added team/cloud-native team/core-clients team/core-iam labels May 6, 2025

vmuzikar reviewed May 6, 2025

View reviewed changes

shawkins force-pushed the iss39428 branch from 654c241 to aa88c1d Compare May 6, 2025 17:37

keycloak-github-bot Bot mentioned this pull request May 6, 2025

Flaky test: org.keycloak.testsuite.model.session.OfflineSessionPersistenceTest#testPersistenceMultipleNodesClientSessionsAtRandomNode #39429

Closed

shawkins force-pushed the iss39428 branch from aa88c1d to 26f1033 Compare May 7, 2025 11:57

keycloak-github-bot Bot reviewed May 7, 2025

View reviewed changes

mabartos approved these changes May 7, 2025

View reviewed changes

keycloak-github-bot Bot reviewed May 7, 2025

View reviewed changes

vmuzikar approved these changes May 7, 2025

View reviewed changes

vmuzikar enabled auto-merge (squash) May 7, 2025 15:18

keycloak-github-bot Bot reviewed May 7, 2025

View reviewed changes

shawkins added 2 commits May 8, 2025 09:14

fix: removing KeycloakApplication usage of keycloak-add-user.json

dab71a8

closes:keycloak#39428 Signed-off-by: Steve Hawkins <[email protected]>

Removing the test keycloak-add-user.json

4712e8a

Signed-off-by: Steve Hawkins <[email protected]>

ahus1 force-pushed the iss39428 branch from 26f1033 to 4712e8a Compare May 8, 2025 07:14

vmuzikar merged commit f40cb88 into keycloak:main May 8, 2025
80 checks passed

keycloak-github-bot Bot reviewed May 8, 2025

View reviewed changes

shawkins mentioned this pull request May 21, 2025

Remove keycloak-add-user.json handling from KeycloakApplication #39428

Closed

Conversation

shawkins commented May 5, 2025

Uh oh!

vmuzikar left a comment

Choose a reason for hiding this comment

Uh oh!

shawkins commented May 6, 2025

Uh oh!

vmuzikar commented May 6, 2025

Uh oh!

shawkins commented May 6, 2025

Uh oh!

keycloak-github-bot Bot left a comment

Choose a reason for hiding this comment

Uh oh!

keycloak-github-bot Bot commented May 7, 2025

Unreported flaky test detected

org.keycloak.testsuite.adapter.servlet.SAMLServletAdapterTest#multiTenant2SamlTest

Uh oh!

mabartos left a comment

Choose a reason for hiding this comment

Uh oh!

keycloak-github-bot Bot left a comment

Choose a reason for hiding this comment

Uh oh!

keycloak-github-bot Bot commented May 7, 2025

Unreported flaky test detected

org.keycloak.testsuite.adapter.servlet.SAMLServletAdapterTest#multiTenant2SamlTest

Uh oh!

vmuzikar left a comment

Choose a reason for hiding this comment

Uh oh!

keycloak-github-bot Bot left a comment

Choose a reason for hiding this comment

Uh oh!

keycloak-github-bot Bot commented May 7, 2025

Unreported flaky test detected

org.keycloak.testsuite.adapter.servlet.SAMLServletAdapterTest#multiTenant2SamlTest

Uh oh!

Uh oh!

keycloak-github-bot Bot left a comment

Choose a reason for hiding this comment

Uh oh!

keycloak-github-bot Bot commented May 8, 2025

Unreported flaky test detected

org.keycloak.testsuite.cluster.SessionFailoverClusterTest#sessionFailover

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants