Fixed how multi-value attributes are modified in jpa model adapters#41432
Fixed how multi-value attributes are modified in jpa model adapters#41432mduchrow wants to merge 2 commits intokeycloak:mainfrom
Conversation
sguilhen
left a comment
There was a problem hiding this comment.
I like the proposed changes to how the attributes are handled, but I think we could simplify the tests if we add them directly to tests/base/ along with other group/user tests there.
|
@ahus1 @pedroigor adding you as reviewers as well - when you have some time please take a look. |
|
@mduchrow Could you please:
I've already prepared a test method to be run in the current |
Aligned handling of setAttribute() in UserAdapter, RoleAdapter and GroupAdapter Closes keycloak#38526 Signed-off-by: mduchrow <[email protected]>
be07987 to
7730f16
Compare
|
Thanks for cleaning up! 👍 I tried to test it locally, but it's still not possible to remove single attribute values if you have the same value multiple times. What I tried:
|
|
For your reference, I added a test to a fork of your PR: dasniko@826848b Unfortunately, I don't get it to provide my changes as a PR to this PR... 🤪 |
Aligned handling of setAttribute() in UserAdapter, RoleAdapter and GroupAdapter.
Duplicate values in the same attribute are now handled correctly. Duplicate values can be added and removed.
Closes #38526