Skip to content

Stop looking up client in ClientAssertionState to prevent lookup by clientId in federated client authentication#44448

Merged
stianst merged 1 commit intokeycloak:mainfrom
stianst:fed-client-stop-clientId-lookup
Nov 26, 2025
Merged

Stop looking up client in ClientAssertionState to prevent lookup by clientId in federated client authentication#44448
stianst merged 1 commit intokeycloak:mainfrom
stianst:fed-client-stop-clientId-lookup

Conversation

@stianst
Copy link
Copy Markdown
Contributor

@stianst stianst commented Nov 25, 2025

Closes #44447

Signed-off-by: stianst [email protected]

@stianst stianst requested a review from a team as a code owner November 25, 2025 07:30
…lientId in federated client authentication

Closes keycloak#44447

Signed-off-by: stianst <[email protected]>
@stianst stianst force-pushed the fed-client-stop-clientId-lookup branch from 7da8f28 to 394c1d2 Compare November 25, 2025 07:40
@stianst stianst merged commit 2acfd41 into keycloak:main Nov 26, 2025
82 checks passed
@stianst stianst deleted the fed-client-stop-clientId-lookup branch November 26, 2025 05:31
Jonaka3385 pushed a commit to Jonaka3385/keycloak that referenced this pull request Nov 26, 2025
…lientId in federated client authentication (keycloak#44448)

Closes keycloak#44447

Signed-off-by: stianst <[email protected]>
Jonaka3385 pushed a commit to Jonaka3385/keycloak that referenced this pull request Nov 26, 2025
# This is the 1st commit message:

Fix race condition in SAML DocumentBuilderFactory creation

Closes keycloak#44438

Signed-off-by: martins <[email protected]>
Signed-off-by: Alexander Schwartz <[email protected]>
Co-authored-by: Alexander Schwartz <[email protected]>
# The commit message keycloak#2 will be skipped:

# fix keycloak#43819 - partial import fails to overwrite existing groups (keycloak#43924)
#
# * fix keycloak#43819 - partial import fails to overwrite existing groups
#
# - when removal is delayed until insertion of the newly imported group
#   this causes a duplicate key constrain violation (`Key (realm_id, parent_group, name)`)
# - fixed by flushing group removals
#
# Signed-off-by: Martin Nowak <[email protected]>
#
# * adding a test and using a general fix
#
# Signed-off-by: Steve Hawkins <[email protected]>
# # Conflicts:
# #	services/src/main/java/org/keycloak/partialimport/PartialImportManager.java
#
# ---------
#
# Signed-off-by: Martin Nowak <[email protected]>
# Signed-off-by: Steve Hawkins <[email protected]>
# Co-authored-by: Steve Hawkins <[email protected]>

# The commit message keycloak#3 will be skipped:

# Always allow to setup JWKS URL in oidc idp
#
# Closes keycloak#44217
#
# Signed-off-by: Giuseppe Graziano <[email protected]>

# The commit message keycloak#4 will be skipped:

# Update translation files (keycloak#44444)
#
# Updated by "Cleanup translation files" hook in Weblate.
#
# Signed-off-by: Hosted Weblate <[email protected]>

# The commit message keycloak#5 will be skipped:

# Promote MDC Logging Feature to Supported State
#
# Closes keycloak#41205
#
# Signed-off-by: Ruchika Jha <[email protected]>
# Signed-off-by: Alexander Schwartz <[email protected]>
# Co-authored-by: Ruchika Jha <[email protected]>
# Co-authored-by: Alexander Schwartz <[email protected]>

# The commit message keycloak#6 will be skipped:

# Stop looking up client in ClientAssertionState to prevent lookup by clientId in federated client authentication (keycloak#44448)
#
# Closes keycloak#44447
#
# Signed-off-by: stianst <[email protected]>

# The commit message keycloak#7 will be skipped:

# When joining a group, don't rely on cached values if user has already been updated
#
# Closes keycloak#44480
#
# Signed-off-by: Alexander Schwartz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ClientAuthenticationFlowContextSupplier always attempts to lookup user by token subject

2 participants