Skip to content

OIDC identity provider issuer config #45591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mposolda merged 1 commit into from
Jan 20, 2026
Merged

OIDC identity provider issuer config #45591

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .../src/main/java/org/keycloak/broker/jwtauthorizationgrant/JWTAuthorizationGrantConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

import static org.keycloak.broker.oidc.OIDCIdentityProviderConfig.JWKS_URL;
import static org.keycloak.broker.oidc.OIDCIdentityProviderConfig.USE_JWKS_URL;
import static org.keycloak.protocol.oidc.OIDCLoginProtocol.ISSUER;
import static org.keycloak.models.IdentityProviderModel.ISSUER;

public interface JWTAuthorizationGrantConfig {

Expand Down
86 changes: 86 additions & 0 deletions ...ase/src/test/java/org/keycloak/tests/admin/identityprovider/IdentityProviderOidcTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,11 @@
import jakarta.ws.rs.core.Response;

import org.keycloak.admin.client.resource.IdentityProviderResource;
import org.keycloak.broker.oidc.OAuth2IdentityProviderConfig;
import org.keycloak.broker.oidc.OIDCIdentityProviderConfig;
import org.keycloak.common.enums.SslRequired;
import org.keycloak.events.Errors;
import org.keycloak.events.EventType;
import org.keycloak.events.admin.OperationType;
import org.keycloak.events.admin.ResourceType;
import org.keycloak.models.IdentityProviderMapperModel;
Expand All @@ -33,10 +37,22 @@
import org.keycloak.representations.idm.ComponentRepresentation;
import org.keycloak.representations.idm.ErrorRepresentation;
import org.keycloak.representations.idm.IdentityProviderRepresentation;
import org.keycloak.testframework.annotations.InjectEvents;
import org.keycloak.testframework.annotations.InjectRealm;
import org.keycloak.testframework.annotations.KeycloakIntegrationTest;
import org.keycloak.testframework.events.AdminEventAssertion;
import org.keycloak.testframework.events.EventAssertion;
import org.keycloak.testframework.events.Events;
import org.keycloak.testframework.oauth.OAuthClient;
import org.keycloak.testframework.oauth.annotations.InjectOAuthClient;
import org.keycloak.testframework.realm.ManagedRealm;
import org.keycloak.testframework.realm.RealmConfig;
import org.keycloak.testframework.realm.RealmConfigBuilder;
import org.keycloak.testframework.ui.annotations.InjectPage;
import org.keycloak.testframework.ui.page.LoginPage;
import org.keycloak.tests.utils.admin.AdminEventPaths;
import org.keycloak.testsuite.util.broker.OIDCIdentityProviderConfigRep;
import org.keycloak.testsuite.util.oauth.AccessTokenResponse;

import org.junit.jupiter.api.Assertions;
import org.junit.jupiter.api.Test;
Expand All @@ -58,6 +74,18 @@
@KeycloakIntegrationTest
public class IdentityProviderOidcTest extends AbstractIdentityProviderTest {

@InjectRealm(ref = "external-realm", config = ExternalRealmConfig.class)
ManagedRealm externalRealm;

@InjectOAuthClient
OAuthClient oauth;

@InjectPage
LoginPage loginPage;

@InjectEvents
Events events;

@Test
public void testCreateWithReservedCharacterForAlias() {
IdentityProviderRepresentation newIdentityProvider = createRep("ne$&w-identity-provider", "oidc");
Expand Down Expand Up @@ -491,4 +519,62 @@ public void testNoExport() {

managedRealm.cleanup().add(r -> r.identityProviders().get(id).remove());
}

@Test
public void testOIDCIdentityProviderLoginIssuerValidation() {
IdentityProviderRepresentation newIdentityProvider = createRep("external-idp", "oidc");
newIdentityProvider.getConfig().put(OIDCIdentityProviderConfig.ISSUER, "bad-issuer");
newIdentityProvider.getConfig().put("clientId", "test-client");
newIdentityProvider.getConfig().put("clientSecret", "password");
newIdentityProvider.getConfig().put(IdentityProviderModel.SYNC_MODE, "IMPORT");
newIdentityProvider.getConfig().put(OAuth2IdentityProviderConfig.TOKEN_ENDPOINT_URL, "http://localhost:8080/realms/external-realm/protocol/openid-connect/token");
newIdentityProvider.getConfig().put("authorizationUrl", "http://localhost:8080/realms/external-realm/protocol/openid-connect/auth");
newIdentityProvider.getConfig().put(OIDCIdentityProviderConfig.JWKS_URL, "http://localhost:8080/realms/external-realm/protocol/openid-connect/certs");
newIdentityProvider.getConfig().put(OIDCIdentityProviderConfig.USE_JWKS_URL, "true");
create(newIdentityProvider);

events.skipAll();
oauth.openLoginForm();
loginPage.clickSocial("external-idp");
loginPage.fillLogin("testuser", "password");
loginPage.submit();
EventAssertion.assertError(events.poll())
.type(EventType.IDENTITY_PROVIDER_LOGIN_ERROR)
.sessionId(null)
.error(Errors.IDENTITY_PROVIDER_LOGIN_FAILURE);

//test correct issuer
managedRealm.updateIdentityProviderWithCleanup("external-idp", rep -> {
rep.getConfig().put(OIDCIdentityProviderConfig.ISSUER, "http://localhost:8080/realms/external-realm");
});

oauth.openLoginForm();
loginPage.clickSocial("external-idp");
AccessTokenResponse tokenResponse = oauth.doAccessTokenRequest(oauth.parseLoginResponse().getCode());
Assertions.assertTrue(tokenResponse.isSuccess());

oauth.logoutRequest().idTokenHint(tokenResponse.getIdToken()).send();
oauth.logoutRequest().send();
}

public static class ExternalRealmConfig implements RealmConfig {

@Override
public RealmConfigBuilder configure(RealmConfigBuilder realm) {
realm.name("external-realm");

realm.addClient("test-client")
.secret("password")
.redirectUris("*");

realm.addUser("testuser")
.name("Test", "User")
.email("test@localhost")
.emailVerified(Boolean.TRUE)
.password("password");

return realm;
}
}

}
Loading