LGTM as long as tests are OK.

Just 2 minor things:

• DCO should be fixed (by adding signature to the commit)
• Will be good to remove the label and tooltip signedMetadataLifespan and signedMetadataLifespanHelp as it seems those are not used anymore

LGTM as long as tests are OK.

Just 2 minor things:

• DCO should be fixed (by adding signature to the commit)
• Will be good to remove the label and tooltip signedMetadataLifespan and signedMetadataLifespanHelp as it seems those are not used anymore

I think there may be a small mix-up in the key names. signedMetadataLifespan and signedMetadataLifespanHelp are still used by the lifespan field in TokensTab.tsx, so removing them would break the label/help text for that control. The keys that became unused with this change are signedIssuerMetadata and signedIssuerMetadataHelp, which belonged to the removed toggle @mposolda.

LGTM as long as tests are OK.
Just 2 minor things:

• DCO should be fixed (by adding signature to the commit)
• Will be good to remove the label and tooltip signedMetadataLifespan and signedMetadataLifespanHelp as it seems those are not used anymore

I think there may be a small mix-up in the key names. signedMetadataLifespan and signedMetadataLifespanHelp are still used by the lifespan field in TokensTab.tsx, so removing them would break the label/help text for that control. The keys that became unused with this change are signedIssuerMetadata and signedIssuerMetadataHelp, which belonged to the removed toggle @mposolda.

Yes, you are right. I am sorry for the confusion. I meant to remove those, which are unused ( signedIssuerMetadata and signedIssuerMetadataHelp)

@Ogenbertrand Could you please rebase on top of latest main? The build error should be fixed already.

Translation Changes Notification

Language maintainers: Please review the translation changes in your language in Weblate.

The following languages have been updated in this PR:

Spanish (es)

@herver1971, @anthieni

Changes waiting for approval.

French (fr)

@Dodouce, @GitSpoon

Changes waiting for approval.

Russian (ru)

@petrov9, @pasternake

Changes waiting for approval.

Swedish (sv)

@yeager, @haaninjo

Changes waiting for approval.

Turkish (tr)

@spctr, @ariferol

Changes waiting for approval.

Simplified Chinese (zh_Hans)

@jasonqsong, @charliedcc

Changes waiting for approval.

Traditional Chinese (zh_Hant)

@allen0099, @benwater12

Changes waiting for approval.