Fix declarative UI page change with signaled data table loading#48413
Open
jonathancgt wants to merge 1 commit intokeycloak:mainfrom
Open
Fix declarative UI page change with signaled data table loading#48413jonathancgt wants to merge 1 commit intokeycloak:mainfrom
jonathancgt wants to merge 1 commit intokeycloak:mainfrom
Conversation
Signed-off-by: Jonathan Ciak <[email protected]>
6ce929d to
bb28eb7
Compare
Member
|
@edewit - can you please have a look as you would have probably the best knowledge in this area? |
Unreported flaky test detectedIf the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR. org.keycloak.testsuite.authz.PolicyEvaluationTest# |
mckoon
approved these changes
Apr 23, 2026
| }; | ||
| return await adminClient.components.find({ ...params }); | ||
| const loader = { | ||
| signal: { providerId }, |
There was a problem hiding this comment.
This is an elegant way to notify KeycloakDataTable that the route changed, so the useFetch dependencies will trigger it to run again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #48284