Skip to content

Fix log messages in workflow step providers #48421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pedroigor merged 1 commit into from
Apr 23, 2026
Merged

Fix log messages in workflow step providers #48421

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 2 additions & 10 deletions model/jpa/src/main/java/org/keycloak/models/workflow/DefaultWorkflowProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,11 +173,7 @@ public void submit(WorkflowEvent event) {

@Override
public void runScheduledSteps() {
getWorkflows().forEach((workflow) -> {
if (!workflow.isEnabled()) {
log.debugf("Skipping workflow %s as it is disabled", workflow.getName());
return;
}
getWorkflows().filter(Workflow::isEnabled).forEach((workflow) -> {
stateProvider.getDueScheduledSteps(workflow).forEach((scheduled) -> {
try {
// check if the resource still meets the workflow's resource conditions
Expand Down Expand Up @@ -369,11 +365,7 @@ private WorkflowProvider getWorkflowProvider(Workflow workflow) {
private void processEvent(Stream<Workflow> workflows, WorkflowEvent event) {
Map<String, ScheduledStep>[] scheduledSteps = new Map[] { null };

workflows.forEach(workflow -> {
if (!workflow.isEnabled()) {
log.debugf("Skipping workflow %s as it is disabled or has no steps", workflow.getName());
return;
}
workflows.filter(Workflow::isEnabled).forEach(workflow -> {

EventBasedWorkflow provider = new EventBasedWorkflow(session, workflow.getSupportedType(), getWorkflowComponent(workflow.getId()));

Expand Down
2 changes: 1 addition & 1 deletion services/src/main/java/org/keycloak/models/workflow/AddRequiredActionStepProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ public void run(WorkflowExecutionContext context) {
log.warnv("Required action {0} is not enabled in realm {1}", action, realm.getName());
return;
}
log.debugv("Adding required action {0} to user {1})", action, user.getId());
log.debugv("Adding required action {0} to user {1}", action, user.getId());
user.addRequiredAction(action);
} catch (IllegalArgumentException e) {
log.warnv("Invalid required action {0} configured in {1}", stepModel.getConfig().getFirst(REQUIRED_ACTION_KEY),
Expand Down
2 changes: 1 addition & 1 deletion services/src/main/java/org/keycloak/models/workflow/GrantRoleStepProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ protected GrantRoleStepProvider(KeycloakSession session, ComponentModel model) {

@Override
protected void run(UserModel user, RoleModel role) {
log.debugv("Granting role %s to user %s)", role.getName(), user.getId());
log.debugv("Granting role {0} to user {1}", role.getName(), user.getId());
user.grantRole(role);
}
}
2 changes: 1 addition & 1 deletion services/src/main/java/org/keycloak/models/workflow/JoinGroupStepProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ protected JoinGroupStepProvider(KeycloakSession session, ComponentModel model) {

@Override
protected void run(UserModel user, GroupModel group) {
log.debugv("Adding user %s to group %s)", user.getId(), buildGroupPath(group));
log.debugv("Adding user {0} to group {1}", user.getId(), buildGroupPath(group));
user.joinGroup(group);
}
}
2 changes: 1 addition & 1 deletion services/src/main/java/org/keycloak/models/workflow/LeaveGroupStepProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ protected LeaveGroupStepProvider(KeycloakSession session, ComponentModel model)

@Override
protected void run(UserModel user, GroupModel group) {
log.debugv("Removing user %s from group %s)", user.getId(), buildGroupPath(group));
log.debugv("Removing user {0} from group {1}", user.getId(), buildGroupPath(group));
user.leaveGroup(group);
}
}
2 changes: 1 addition & 1 deletion services/src/main/java/org/keycloak/models/workflow/RemoveRequiredActionStepProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ public void run(WorkflowExecutionContext context) {
if (user != null) {
try {
UserModel.RequiredAction action = UserModel.RequiredAction.valueOf(stepModel.getConfig().getFirst(REQUIRED_ACTION_KEY));
log.debugv("Removing required action {0} from user {1})", action, user.getId());
log.debugv("Removing required action {0} from user {1}", action, user.getId());
user.removeRequiredAction(action);
} catch (IllegalArgumentException e) {
log.warnv("Invalid required action {0} configured in RemoveRequiredActionStepProvider", stepModel.getConfig().getFirst(REQUIRED_ACTION_KEY));
Expand Down
2 changes: 1 addition & 1 deletion services/src/main/java/org/keycloak/models/workflow/RevokeRoleStepProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ protected RevokeRoleStepProvider(KeycloakSession session, ComponentModel model)

@Override
protected void run(UserModel user, RoleModel role) {
log.debugv("Revoking role %s from user %s)", role.getName(), user.getId());
log.debugv("Revoking role {0} from user {1}", role.getName(), user.getId());
user.deleteRoleMapping(role);
}
}
2 changes: 1 addition & 1 deletion services/src/main/java/org/keycloak/models/workflow/SetUserAttributeStepProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ public void run(WorkflowExecutionContext context) {
String key = entry.getKey();

if (!key.startsWith(CONFIG_AFTER) && !key.startsWith(CONFIG_PRIORITY)) {
log.debugv("Setting attribute {0} to user {1})", key, user.getId());
log.debugv("Setting attribute {0} to user {1}", key, user.getId());
user.setAttribute(key, entry.getValue());
}
}
Expand Down
Loading