Reject CORS requests with invalid Origin before endpoint logic runs#48469
Draft
gaoyikeshuer wants to merge 1 commit intokeycloak:mainfrom
Draft
Reject CORS requests with invalid Origin before endpoint logic runs#48469gaoyikeshuer wants to merge 1 commit intokeycloak:mainfrom
gaoyikeshuer wants to merge 1 commit intokeycloak:mainfrom
Conversation
81354c6 to
336d55f
Compare
4080ce6 to
c437a1c
Compare
Signed-off-by: Yike Gao <[email protected]>
c437a1c to
fdf3854
Compare
Unreported flaky test detectedIf the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR. org.keycloak.testsuite.forms.RPInitiatedFrontChannelLogoutTest#testFrontChannelLogoutWithoutSessionRequiredKeycloak CI - Forms IT (firefox) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR links to #45957
This PR chnages CORS handling from late response to early request validation for endpoints that already know their allowed origins.
Before this change, and invalid Origin could still reach the endpoint logic and trigger work, with CORS only failing later when response header were added. After this change, request with an invalid Origin are rejected immediatly with 403, before endpoint logic runs