Synchronize workflow scheduled settings using cluster events (#48422)#48501
Merged
pedroigor merged 3 commits intokeycloak:release/26.6from Apr 27, 2026
Merged
Synchronize workflow scheduled settings using cluster events (#48422)#48501pedroigor merged 3 commits intokeycloak:release/26.6from
pedroigor merged 3 commits intokeycloak:release/26.6from
Conversation
…k#48422) Closes keycloak#48185 Signed-off-by: Stefan Guilhen <[email protected]> (cherry picked from commit 33651e4)
08f6e92 to
ed7ec51
Compare
Signed-off-by: Stefan Guilhen <[email protected]> (cherry picked from commit 33651e4)
ryanemerson
reviewed
Apr 27, 2026
| assertCompatibility(CompatibilityResult.ExitCode.RECREATE, compatibilityProvider.isCompatible(Map.of(VERSION_KEY, "999.998.999-Final", "new cluster event", "WorkflowScheduleClusterEvent"))); | ||
| assertCompatibility(CompatibilityResult.ExitCode.RECREATE, compatibilityProvider.isCompatible(Map.of(VERSION_KEY, "998.999.999-Final", "new cluster event", "WorkflowScheduleClusterEvent"))); | ||
| assertCompatibility(CompatibilityResult.ExitCode.RECREATE, compatibilityProvider.isCompatible(Map.of(VERSION_KEY, "999.998.998-Final", "new cluster event", "WorkflowScheduleClusterEvent"))); | ||
| assertCompatibility(CompatibilityResult.ExitCode.RECREATE, compatibilityProvider.isCompatible(Map.of(VERSION_KEY, "998.999.998-Final", "new cluster event", "WorkflowScheduleClusterEvent"))); |
Contributor
There was a problem hiding this comment.
I think we need a test case to represent when we upgrade from 26.6.1 to 26.6.2, i.e. the "new cluster event" K and Value are missing:
assertCompatibility(CompatibilityResult.ExitCode.RECREATE, compatibilityProvider.isCompatible(Map.of(VERSION_KEY, "999.999.999-Final")));
Contributor
Author
There was a problem hiding this comment.
@ryanemerson I thought that was implicitly covered in testRollingUpgradeRefusedWithOtherMetadataNotEquals, but I can add something targetting the versions
Contributor
Author
There was a problem hiding this comment.
Done, added the assertion as you've suggested.
…ation Signed-off-by: Stefan Guilhen <[email protected]> (cherry picked from commit 33651e4)
5e498ea to
be648c2
Compare
pruivo
approved these changes
Apr 27, 2026
pedroigor
approved these changes
Apr 27, 2026
pedroigor
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #48185
(cherry picked from commit 33651e4)