Remove noisy console.error in the fetchWithError function#48518
Open
CyanoFresh wants to merge 1 commit intokeycloak:mainfrom
Open
Remove noisy console.error in the fetchWithError function#48518CyanoFresh wants to merge 1 commit intokeycloak:mainfrom
CyanoFresh wants to merge 1 commit intokeycloak:mainfrom
Conversation
Signed-off-by: Alex Solomaha <[email protected]>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the fetchWithError helper in the Keycloak admin client JS library to avoid producing side-effect logging, keeping error reporting consistent with the consumer’s JSON logging/handling.
Changes:
- Removed a
console.error(...)statement emitted on non-OK HTTP responses. - Preserved existing behavior of parsing the response body and throwing
NetworkErrorwith{ response, responseData }.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes a small change to the
fetchWithErrorutility function. It removes a noisyconsole.errorstatement that was previously logging error messages, HTTP status, and response data to the console.We have our own (json) handler, and this lib should not alter our logging behavior