[Backport 26.6] fix: validate resource type consistency when adding resources to FGAP permissions#48519
Merged
stianst merged 1 commit intokeycloak:release/26.6from Apr 28, 2026
Conversation
… permissions Previously, getOrCreateResource() would return any resource found by its authz DB ID without verifying it belonged to the requested resource type. This allowed resources of one type (e.g. Users) to be silently added to a permission of a different type (e.g. Groups) by passing the internal authz resource ID. - For per-entity resources found by ID, validate the name resolves as the expected entity type via getResourceName(); throw ModelValidationException on mismatch Closes keycloak#37243 Signed-off-by: Vinit Kumar <[email protected]>
vramik
approved these changes
Apr 27, 2026
stianst
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, getOrCreateResource() would return any resource found by its authz DB ID without verifying it belonged to the requested resource type. This allowed resources of one type (e.g. Users) to be silently added to a permission of a different type (e.g. Groups) by passing the internal authz resource ID.
Closes #37243