Migrated UserSessionLimitsTest and UserSessionLimitsUtils by msdaly200 · Pull Request #48187 · keycloak/keycloak

msdaly200 · 2026-04-17T10:20:47Z

Migrated UserSessionLimitsTest and UserSessionLimitsUtils files from Arquillian to new test framework.
Minor debug change to UserSessionLimitsAuthenticator.

keycloak-github-bot · 2026-04-17T11:03:34Z

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.adapter.servlet.SAMLServletAdapterTest#salesMetadataTest

Keycloak CI - Adapter IT Strict Cookies

java.lang.AssertionError
	at org.junit.Assert.fail(Assert.java:87)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.junit.Assert.assertTrue(Assert.java:53)
	at org.keycloak.testsuite.adapter.servlet.SAMLServletAdapterTest.assertForbiddenLogin(SAMLServletAdapterTest.java:558)
...

Report flaky test

keycloak-github-bot

Unreported flaky test detected, please review

rmartinc

Thanks a lot @msdaly200 for the PR!

Just a few nitpicks for you to consider.

vaceksimon

Identified a couple of areas for improvement. This is a pretty long class, kudos Marie

rmartinc

Just one nitpick more and for me the PR is ready. Don't know if @vaceksimon is OK too.

keycloak-github-bot

Unreported flaky test detected, please review

keycloak-github-bot · 2026-04-23T16:23:52Z

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.authz.PolicyEvaluationTest#

Keycloak CI - Base IT (3)

org.opentest4j.AssertionFailedError: expected: <PERMIT> but was: <null>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
	at org.junit.jupiter.api.AssertEquals.failNotEqual(AssertEquals.java:197)
	at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:182)
...

org.opentest4j.AssertionFailedError: expected: <PERMIT> but was: <null>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
	at org.junit.jupiter.api.AssertEquals.failNotEqual(AssertEquals.java:197)
	at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:182)
...

org.opentest4j.AssertionFailedError: expected: <PERMIT> but was: <null>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
	at org.junit.jupiter.api.AssertEquals.failNotEqual(AssertEquals.java:197)
	at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:182)
...

Report flaky test

rmartinc

Thanks @msdaly200! LGTM! Let's see if @vaceksimon is OK.

vaceksimon

LGTM, thanks @msdaly200 !

…ework Signed-off-by: Marie Daly <[email protected]>

Signed-off-by: Marie Daly <[email protected]>

mposolda

Merging on behalf of @rmartinc and @vaceksimon reviews.

…48187) Closes keycloak#48170 Signed-off-by: Marie Daly <[email protected]>

msdaly200 requested review from a team as code owners April 17, 2026 10:20

keycloak-github-bot Bot added team/cloud-native team/core-clients team/core-iam flaky-test labels Apr 17, 2026

keycloak-github-bot Bot reviewed Apr 17, 2026

View reviewed changes

msdaly200 force-pushed the 48170 branch 2 times, most recently from 52586f8 to 0e406aa Compare April 20, 2026 12:14

vaceksimon self-requested a review April 21, 2026 07:10

rmartinc suggested changes Apr 21, 2026

View reviewed changes

vaceksimon suggested changes Apr 21, 2026

View reviewed changes

msdaly200 force-pushed the 48170 branch from e5b1380 to 5b0a401 Compare April 21, 2026 16:10

msdaly200 requested a review from a team as a code owner April 21, 2026 16:10

keycloak-github-bot Bot added the team/ui label Apr 21, 2026

msdaly200 force-pushed the 48170 branch 2 times, most recently from e285dd5 to f1d6f98 Compare April 22, 2026 09:04

msdaly200 requested a review from a team as a code owner April 22, 2026 09:04

msdaly200 force-pushed the 48170 branch 3 times, most recently from 1f5efa4 to ae3084c Compare April 22, 2026 09:16

keycloak-github-bot Bot mentioned this pull request Apr 22, 2026

Flaky test: org.keycloak.testsuite.forms.AuthenticatorSubflowsTest2#testSubflow2 #47477

Closed

msdaly200 force-pushed the 48170 branch 2 times, most recently from 6784360 to 8728897 Compare April 23, 2026 08:56

msdaly200 force-pushed the 48170 branch 2 times, most recently from 94e28b7 to 429b31c Compare April 23, 2026 09:10

rmartinc suggested changes Apr 23, 2026

View reviewed changes

Comment thread tests/base/src/test/java/org/keycloak/tests/sessionlimits/UserSessionLimitsTest.java Outdated

msdaly200 force-pushed the 48170 branch from 429b31c to e619f40 Compare April 23, 2026 14:25

keycloak-github-bot Bot reviewed Apr 23, 2026

View reviewed changes

rmartinc approved these changes Apr 24, 2026

View reviewed changes

msdaly200 force-pushed the 48170 branch from e619f40 to 8dd8558 Compare April 24, 2026 08:15

vaceksimon approved these changes Apr 24, 2026

View reviewed changes

msdaly200 force-pushed the 48170 branch from 8dd8558 to 771657f Compare April 24, 2026 09:05

keycloak-github-bot Bot mentioned this pull request Apr 24, 2026

Flaky test: org.keycloak.testsuite.authz.PolicyEvaluationTest# #48446

Open

msdaly200 force-pushed the 48170 branch from 771657f to 3e687f6 Compare April 24, 2026 09:45

msdaly200 added 5 commits April 24, 2026 11:30

Closes keycloak#48170: Migrate UserSessionLimitsTest to new test fram…

6e3e0a2

…ework Signed-off-by: Marie Daly <[email protected]>

Closes keycloak#48170, update after merge

a23df39

Signed-off-by: Marie Daly <[email protected]>

Closes keycloak#48170, updated following review

18ec32d

Signed-off-by: Marie Daly <[email protected]>

Closes keycloak#48170, resolve spotless issue

e6e74e1

Signed-off-by: Marie Daly <[email protected]>

Closes keycloak#48170, remove keycloakUrls

217cec8

Signed-off-by: Marie Daly <[email protected]>

msdaly200 force-pushed the 48170 branch from 3e687f6 to 217cec8 Compare April 24, 2026 10:30

mposolda approved these changes Apr 24, 2026

View reviewed changes

mposolda merged commit 766a872 into keycloak:main Apr 24, 2026
85 checks passed

ahus1 pushed a commit to ahus1/keycloak that referenced this pull request Apr 24, 2026

Migrated UserSessionLimitsTest and UserSessionLimitsUtils (keycloak#…

f7cfe37

…48187) Closes keycloak#48170 Signed-off-by: Marie Daly <[email protected]>

Conversation

msdaly200 commented Apr 17, 2026

Uh oh!

keycloak-github-bot Bot commented Apr 17, 2026

Unreported flaky test detected

org.keycloak.testsuite.adapter.servlet.SAMLServletAdapterTest#salesMetadataTest

Uh oh!

keycloak-github-bot Bot left a comment

Choose a reason for hiding this comment

Uh oh!

rmartinc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vaceksimon left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rmartinc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

keycloak-github-bot Bot left a comment

Choose a reason for hiding this comment

Uh oh!

keycloak-github-bot Bot commented Apr 23, 2026

Unreported flaky test detected

org.keycloak.testsuite.authz.PolicyEvaluationTest#

Uh oh!

rmartinc left a comment

Choose a reason for hiding this comment

Uh oh!

vaceksimon left a comment

Choose a reason for hiding this comment

Uh oh!

mposolda left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

vaceksimon left a comment •

edited

Loading