[OID4VCI]: Fix OID4VCI resource Date headers for conformance and add regression tests#48277
Open
forkimenjeckayang wants to merge 1 commit intokeycloak:mainfrom
Open
[OID4VCI]: Fix OID4VCI resource Date headers for conformance and add regression tests#48277forkimenjeckayang wants to merge 1 commit intokeycloak:mainfrom
forkimenjeckayang wants to merge 1 commit intokeycloak:mainfrom
Conversation
f64a66d to
2c35852
Compare
Unreported flaky test detectedIf the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR. org.keycloak.testsuite.forms.RPInitiatedFrontChannelLogoutTest#testFrontChannelLogoutWithoutSessionRequiredKeycloak CI - Forms IT (firefox) |
Contributor
|
This already works AFAICS |
Contributor
Author
Somehow , it's not. I updated the branch which this depends on with latest changes from main ie |
…tests Signed-off-by: forkimenjeckayang <[email protected]>
0f90036 to
eb516c8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dateheaders to OID4VCI resource responses and issuer metadata endpoints used by conformance checks.Dateheader values are emitted in RFC1123 format to satisfy strict conformance validation.Dateheader presence and parseability on nonce and well-known issuer endpoints.Why
The conformance test
oid4vci-1_0-issuer-happy-flowfailed onCheckForDateHeaderInResourceResponse (RFC7231-7.1.1.2)because resource responses were missing a validDateheader.Depends on: #48048
Related to : #46265
See: adorsys#245 (comment)