Unify Testing client and RunOnServer APIs for smoother test migration#48363
Unify Testing client and RunOnServer APIs for smoother test migration#48363vaceksimon wants to merge 5 commits intokeycloak:mainfrom
Conversation
stianst
left a comment
There was a problem hiding this comment.
This can be simplified and made cleaner.
For example if you have RunOnServerUtils has something like:
public static RunOnServer printRealm(String realm) {
return session -> System.out.println(session.realms().getRealmByName(realm).getDisplayName());
}
Then you can use it with runOnServer.run(RunOnServerUtils.printRealm("asdfsadf")), which removes the need to have the session -> part and also passing session to the method.
You should probably also call it RunOnServerHelpers instead of Utils as that's what we have used for those things in the past.
Finally, this shouldn't be part of the test-framework as these are very internal things, that we don't want to expose. So just add it to the tests/base.
|
@vaceksimon should be in |
|
Well, right now I have two versions of Besides, I don't think we get more benefit from moving it to |
|
@stianst or maybe this new helper should be merged with the already existing |
Signed-off-by: Simon Vacek <[email protected]> # Conflicts: # testsuite/integration-arquillian/tests/base/src/test/java/org/keycloak/testsuite/forms/LoginTest.java
Signed-off-by: Simon Vacek <[email protected]>
Signed-off-by: Simon Vacek <[email protected]>
Signed-off-by: Simon Vacek <[email protected]>
Signed-off-by: Simon Vacek <[email protected]>
43cf6e4 to
57250cd
Compare
Closes #48319