Escape expressions in JS blocks in FTL pages#48369
Open
mabartos wants to merge 1 commit intokeycloak:mainfrom
Open
Escape expressions in JS blocks in FTL pages#48369mabartos wants to merge 1 commit intokeycloak:mainfrom
mabartos wants to merge 1 commit intokeycloak:mainfrom
Conversation
Contributor
mabartos
commented
Apr 22, 2026
- Closes Escape expressions in JS blocks in FTL pages #48348
Closes keycloak#48348 Signed-off-by: Martin Bartoš <[email protected]>
Unreported flaky test detectedIf the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR. org.keycloak.testsuite.federation.ldap.LDAPGroupMapperTest#test01_ldapOnlyGroupMappings |
rmartinc
approved these changes
Apr 23, 2026
Contributor
rmartinc
left a comment
There was a problem hiding this comment.
Thanks @mabartos! For me it's OK but don't know if maybe testing this in 4 different tests is not too many. With the LoginTemplateJsEscapingTest.java is more than enough for me. There will be errors if we change the javascript in the templates. But, I'm approving it, the only problem is that we will see test failures when changing the templates that we will need to fix.
| <script type="module"> | ||
| import { startSessionPolling } from "${url.resourcesPath}/js/authChecker.js"; | ||
| <#outputformat "JavaScript"> | ||
| import { startSessionPolling } from ${(url.resourcesPath + "/js/authChecker.js")?c}; |
Contributor
There was a problem hiding this comment.
Checked that it can also be:
import { startSessionPolling } from ${"${url.resourcesPath}/js/authChecker.js"?c};But it's Ok, it was just curiosity. 😄
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.