Handle orphan authenticator providers in flows#48372
Open
erenkan wants to merge 1 commit intokeycloak:mainfrom
Open
Handle orphan authenticator providers in flows#48372erenkan wants to merge 1 commit intokeycloak:mainfrom
erenkan wants to merge 1 commit intokeycloak:mainfrom
Conversation
The admin REST endpoint that lists flow executions threw NotFoundException when an execution referenced a provider id with no registered factory (SPI uninstalled/renamed/failed to register). The Admin UI propagated the 404 to its global error boundary, making the whole flow page uneditable — the admin could not delete the orphan execution or manage the rest of the flow. Backend: populate a placeholder AuthenticationExecutionInfoRepresentation with providerUnavailable=true when the factory lookup returns null, so listing keeps working. AuthenticationExecutionInfoRepresentation gains an optional providerUnavailable Boolean. Admin UI: FlowTitle shows a red "Provider unavailable" badge, FlowRow hides the gear icon, and cross-flow drag is rejected up-front (including when an orphan is nested inside a sub-flow being moved) so the delete + re-create sequence never silently drops the row. Same-flow reorder and delete remain functional. Closes keycloak#15535 Signed-off-by: erenkan <[email protected]>
0dca0fc to
7125f1e
Compare
Contributor
Author
|
Quick question for maintainers on the copyright header of the new test file I removed the
What's your preference?
Happy to push whichever you prefer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #15535
Problem
An authentication flow execution stores only its provider id string. If the referenced SPI is uninstalled, renamed, or fails to register,
GET /admin/realms/{realm}/authentication/flows/{alias}/executionsthrowsNotFoundException("Could not find authenticator provider"). The 404 propagates to the Admin UI's global error boundary and the entire flow page crashes — admins cannot delete the orphan execution, reorder siblings, or edit anything else in the flow.Screen.Recording.2026-04-22.at.17.22.08.mov