Skip to content

KEYCLOAK-1267 Add dedicated SSO timeouts for Remember-Me#5718

Merged
mposolda merged 1 commit intokeycloak:masterfrom
sguilhen:KC1267
Nov 15, 2018
Merged

KEYCLOAK-1267 Add dedicated SSO timeouts for Remember-Me#5718
mposolda merged 1 commit intokeycloak:masterfrom
sguilhen:KC1267

Conversation

@sguilhen
Copy link
Copy Markdown
Contributor

@sguilhen sguilhen commented Nov 14, 2018

Previously remember-me sessions where tied to the SSO max session
timeout which could lead to unexpected early session timeouts.
We now allow SSO timeouts to be configured separately for sessions
with enabled remember-me. This enables users to opt-in for longer
session timeouts.

SSO session timeouts for remember-me can now be configured in the
tokens tab in the realm admin console. This new configuration is
optional and will tipically host values larger than the regular
max SSO timeouts. If no value is specified for remember-me timeouts
then the regular max SSO timeouts will be used.

Work based on PR #3161 by
Thomas Darimont [email protected]. Review by Stian
on the original PR was used as a guideline for the necessary changes,
including:

  • making both remember-me timeouts optional
  • moving the test logic from the adapters testsuite to LoginTest
  • cleaning up unnecessary changes throughout the code

Link for the PR that updates the documentation: keycloak/keycloak-documentation#515

mposolda
mposolda previously approved these changes Nov 14, 2018
Copy link
Copy Markdown
Contributor

@mposolda mposolda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sguilhen Approving, Thanks! We can wait for Matthew if he is fine with the docs

Previously remember-me sessions where tied to the SSO max session
timeout which could lead to unexpected early session timeouts.
We now allow SSO timeouts to be configured separately for sessions
with enabled remember-me. This enables users to opt-in for longer
session timeouts.

SSO session timeouts for remember-me can now be configured in the
tokens tab in the realm admin console. This new configuration is
optional and will tipically host values larger than the regular
max SSO timeouts. If no value is specified for remember-me timeouts
then the regular max SSO timeouts will be used.

Work based on PR keycloak#3161 by
Thomas Darimont <[email protected]>
@sguilhen
Copy link
Copy Markdown
Contributor Author

@mposolda Had to make a small change to one of the tests that failed on travis. Just updated the PR

Copy link
Copy Markdown
Contributor

@mposolda mposolda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sguilhen ah, ok

@mposolda
Copy link
Copy Markdown
Contributor

@keycloak-ci-bot test

@keycloak-ci-bot
Copy link
Copy Markdown

@mposolda Job is scheduled

@mposolda
Copy link
Copy Markdown
Contributor

@keycloak-ci-bot test

@keycloak-ci-bot
Copy link
Copy Markdown

@mposolda Job is scheduled

@mposolda mposolda merged commit cf57a1b into keycloak:master Nov 15, 2018
@sguilhen sguilhen deleted the KC1267 branch November 16, 2018 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants