Add support for wildcards in subdomains for valid redirect URIs#5826
Add support for wildcards in subdomains for valid redirect URIs#5826josh-cain wants to merge 1 commit intokeycloak:masterfrom
Conversation
| <hamcrest.version>1.3</hamcrest.version> | ||
| <jmeter.version>2.10</jmeter.version> | ||
| <junit.version>4.12</junit.version> | ||
| <mockito.version>1.10.19</mockito.version> |
There was a problem hiding this comment.
We have decided not to use mocking frameworks so we can't accept this
| @@ -0,0 +1,117 @@ | |||
| package org.keycloak.protocol.oidc.utils; | |||
There was a problem hiding this comment.
Look at OAuthRedirectUriTest which can be extended to cover these tests properly
|
Hi, any chance this PR will be merged into a Keycloak release soon? |
|
Closing. It's clear that this is not going to happen (at least not with this PR), and it's so stale at this point, might as well re-write it. |
|
@josh-cain Could you link the new PR here if you create one, so I can watch it? |
|
@sharedprophet - my apologies, I can see where that comment was not clear. I have no intentions of re-writing this myself at this point. Per @stianst 's comment, they're not going to take anything with mocks, so a re-write will entail one of:
Pretty sure #1 or #2 above would get rejected, and I don't have the time/patience for #3. Sorry to abandon it, hopefully the community can band together for this one soon! |
See https://issues.jboss.org/browse/KEYCLOAK-3585.
This is a re-work of previous MR.