KEYCLOAK-17379 - Allow resetting the terms and conditions for all users#7841
KEYCLOAK-17379 - Allow resetting the terms and conditions for all users#7841laskasn wants to merge 1 commit intokeycloak:mainfrom
Conversation
Added the option of resetting for existing users the terms_and_conditions required action. Added a test for the new feature
|
First off let me apologize for this PR having been around so long without any feedback. I can see it being useful to being able to batch add a terms and condition to users, especially for terms and conditions. However, this PR does have a couple of issues:
A PR to batch add a required action to users would be something that we would be able to accept if the above to issues are resolved. Not really sure how we can resolve the first one, as it would require some batch update directly to the store itself. An alternative to this approach would be to have some level of versioning/hash perhaps on the T&C. Rather than a user accepting T&C in general they would accept a specific version of the T&C, which would be what is associated with the user in the database. This would allow the T&C action to check if a user has accepted a specific version of the T&C during login. In the end something like that may be significantly easier than dealing with a batch update through the store. I'm going to close this PR for now, but if this is still relevant please open a GitHub Issue, and feel free to send a new PR. |
|
May be related to: #7895 |
Added the option of resetting for existing users the terms_and_conditions required action.
Added a test for the new feature
Description of the pull request can be found here