Skip to content

KEYCLOAK-17379 - Allow resetting the terms and conditions for all users#7841

Closed
laskasn wants to merge 1 commit intokeycloak:mainfrom
eosc-kc:aup-on-demand
Closed

KEYCLOAK-17379 - Allow resetting the terms and conditions for all users#7841
laskasn wants to merge 1 commit intokeycloak:mainfrom
eosc-kc:aup-on-demand

Conversation

@laskasn
Copy link
Copy Markdown
Contributor

@laskasn laskasn commented Mar 9, 2021

Added the option of resetting for existing users the terms_and_conditions required action.
Added a test for the new feature
Description of the pull request can be found here

Added the option of resetting for existing users the terms_and_conditions required action.
Added a test for the new feature
@laskasn laskasn changed the title KEYCLOAK-17379 KEYCLOAK-17379 - Allow resetting the terms and conditions for all users Oct 19, 2021
@stianst
Copy link
Copy Markdown
Contributor

stianst commented Jul 26, 2023

First off let me apologize for this PR having been around so long without any feedback.

I can see it being useful to being able to batch add a terms and condition to users, especially for terms and conditions. However, this PR does have a couple of issues:

  • Iterating over all users in a realm will be incredibly inefficient, and in deployments with larger amount of users this will most likely not even work as the transaction will timeout
  • The updates for the admin console are for the now removed old admin console

A PR to batch add a required action to users would be something that we would be able to accept if the above to issues are resolved. Not really sure how we can resolve the first one, as it would require some batch update directly to the store itself.

An alternative to this approach would be to have some level of versioning/hash perhaps on the T&C. Rather than a user accepting T&C in general they would accept a specific version of the T&C, which would be what is associated with the user in the database. This would allow the T&C action to check if a user has accepted a specific version of the T&C during login. In the end something like that may be significantly easier than dealing with a batch update through the store.

I'm going to close this PR for now, but if this is still relevant please open a GitHub Issue, and feel free to send a new PR.

@stianst stianst closed this Jul 26, 2023
@stianst
Copy link
Copy Markdown
Contributor

stianst commented Jul 26, 2023

May be related to: #7895

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants