Skip to content

[KEYCLOAK-17399] - Review User Profile SPI#7846

Merged
pedroigor merged 1 commit intokeycloak:masterfrom
pedroigor:KEYCLOAK-17399
May 20, 2021
Merged

[KEYCLOAK-17399] - Review User Profile SPI#7846
pedroigor merged 1 commit intokeycloak:masterfrom
pedroigor:KEYCLOAK-17399

Conversation

@pedroigor
Copy link
Copy Markdown
Contributor

@pedroigor pedroigor commented Mar 11, 2021

No description provided.

@pedroigor pedroigor added status/hold PR should not be merged. On hold for later. area/core kind/enhancement Categorizes a PR related to an enhancement labels Mar 11, 2021
@pedroigor pedroigor force-pushed the KEYCLOAK-17399 branch 3 times, most recently from 5747139 to fdb5e31 Compare March 11, 2021 18:18
pedroigor
pedroigor commented Mar 11, 2021
View reviewed changes
Comment thread core/src/main/java/org/keycloak/representations/account/UserRepresentation.java Outdated
pedroigor
pedroigor commented Mar 11, 2021
View reviewed changes
Comment thread server-spi-private/src/main/java/org/keycloak/userprofile/Attributes.java Outdated
pedroigor
pedroigor commented Mar 11, 2021
View reviewed changes
Comment thread server-spi-private/src/main/java/org/keycloak/userprofile/validation/Validator.java Outdated
pedroigor
pedroigor commented Mar 11, 2021
View reviewed changes
Comment thread services/src/main/java/org/keycloak/userprofile/legacy/Validators.java Outdated
@pedroigor pedroigor force-pushed the KEYCLOAK-17399 branch 3 times, most recently from dedc60a to d47d6f1 Compare March 11, 2021 22:55
velias
velias reviewed Mar 12, 2021
View reviewed changes
Comment thread core/src/main/java/org/keycloak/representations/account/UserRepresentation.java Outdated
velias
velias reviewed Mar 12, 2021
View reviewed changes
Comment thread core/src/main/java/org/keycloak/representations/idm/UserRepresentation.java Outdated
velias
velias reviewed Mar 12, 2021
View reviewed changes
Comment thread core/src/main/java/org/keycloak/representations/idm/UserRepresentation.java Outdated
velias
velias reviewed Mar 12, 2021
View reviewed changes
Comment thread model/jpa/src/main/java/org/keycloak/models/jpa/UserAdapter.java Outdated
velias
velias reviewed Mar 12, 2021
View reviewed changes
Comment thread model/map/src/main/java/org/keycloak/models/map/user/MapUserAdapter.java Outdated
velias
velias reviewed Mar 12, 2021
View reviewed changes
Comment thread server-spi-private/src/main/java/org/keycloak/userprofile/DefaultAttributes.java Outdated
velias
velias reviewed Mar 12, 2021
View reviewed changes
Comment thread server-spi-private/src/main/java/org/keycloak/userprofile/DefaultUserProfile.java Outdated
velias
velias reviewed Mar 12, 2021
View reviewed changes
Comment thread server-spi-private/src/main/java/org/keycloak/userprofile/UserProfile.java Outdated
velias
velias reviewed Mar 12, 2021
View reviewed changes
Comment thread server-spi-private/src/main/java/org/keycloak/userprofile/UserProfile.java Outdated
velias
velias reviewed Mar 12, 2021
View reviewed changes
Comment thread server-spi-private/src/main/java/org/keycloak/userprofile/UserProfileContext.java Outdated
velias
velias reviewed Mar 12, 2021
View reviewed changes
Comment thread services/src/main/java/org/keycloak/authentication/forms/RegistrationProfile.java Outdated
velias
velias reviewed Mar 12, 2021
View reviewed changes
Comment thread services/src/main/java/org/keycloak/authentication/forms/RegistrationProfile.java Outdated
velias
velias reviewed Mar 12, 2021
View reviewed changes
Comment thread services/src/main/java/org/keycloak/authentication/requiredactions/UpdateProfile.java Outdated
velias
velias reviewed Mar 12, 2021
View reviewed changes
Comment thread services/src/main/java/org/keycloak/authentication/requiredactions/UpdateProfile.java Outdated
velias
velias reviewed Mar 12, 2021
View reviewed changes
Comment thread services/src/main/java/org/keycloak/authentication/requiredactions/UpdateProfile.java Outdated
velias
velias reviewed Mar 12, 2021
View reviewed changes
Comment thread services/src/main/java/org/keycloak/services/resources/admin/UserResource.java Outdated
@pedroigor pedroigor mentioned this pull request Mar 29, 2021
Closed
@pedroigor pedroigor force-pushed the KEYCLOAK-17399 branch 4 times, most recently from afa8dbc to 7e1771b Compare April 13, 2021 16:16
velias
velias reviewed Apr 15, 2021
View reviewed changes
Comment thread server-spi-private/src/main/java/org/keycloak/userprofile/DefaultUserProfile.java Outdated
hmlnarik
hmlnarik reviewed Apr 15, 2021
View reviewed changes
Comment thread server-spi-private/src/main/java/org/keycloak/userprofile/validation/Validator.java Outdated
@pedroigor pedroigor force-pushed the KEYCLOAK-17399 branch 3 times, most recently from ffe78df to d121355 Compare April 15, 2021 18:37
danielFesenmeyer
danielFesenmeyer reviewed May 3, 2021
View reviewed changes
Comment thread services/src/main/java/org/keycloak/services/resources/admin/UserResource.java Outdated
Copy link
Copy Markdown
Contributor

@danielFesenmeyer danielFesenmeyer May 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to get the actual validation errors instead of this generic error message - in our case the users of the REST API don't have access to the logs, so this message won't really help them. If the response should be kept simple, it would be nice to get at least the first validation error (as it is done in Account REST API).

Copy link
Copy Markdown
Contributor Author

@pedroigor pedroigor May 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danielFesenmeyer I agree. However, we are not changing here legacy behavior but re-working the SPI. Maybe we can track this in a separate JIRA?

Copy link
Copy Markdown
Contributor

@danielFesenmeyer danielFesenmeyer May 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pedroigor: I've created this ticket here as a subtask of the user profile: https://issues.redhat.com/browse/KEYCLOAK-17946. I hope that's the right place - otherwise feel free to move it.

@pedroigor pedroigor force-pushed the KEYCLOAK-17399 branch 8 times, most recently from 97077ed to a9aa967 Compare May 7, 2021 21:39
@pedroigor
Copy link
Copy Markdown
Contributor Author

pedroigor commented May 19, 2021

@velias Rebased with validation changes.

miquelsi
miquelsi approved these changes May 20, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@miquelsi miquelsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job. Thanks Pedro!

@pedroigor pedroigor merged commit a0f8d2b into keycloak:master May 20, 2021
@pedroigor pedroigor deleted the KEYCLOAK-17399 branch August 3, 2021 12:17
@RaffaelGrob
Copy link
Copy Markdown

RaffaelGrob commented Dec 16, 2022

Hi
@pedroigor and @thomasdarimont: Is there a way to configure the declarativeUserProfile using kcadm? I'd appreciate a little help as we would like to be able to deploy a configuration of a declarativeUserProfile by script or code.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stianst stianst stianst approved these changes

@mposolda mposolda Awaiting requested review from mposolda

+4 more reviewers

@velias velias velias left review comments

@hmlnarik hmlnarik hmlnarik left review comments

@danielFesenmeyer danielFesenmeyer danielFesenmeyer left review comments

@miquelsi miquelsi miquelsi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area/core kind/enhancement Categorizes a PR related to an enhancement status/hold PR should not be merged. On hold for later.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@pedroigor @thomasdarimont @RaffaelGrob @velias @miquelsi @stianst @hmlnarik @danielFesenmeyer