KEYCLOAK-15595: update keycloak js for KEYCLOAK-15595#8011
KEYCLOAK-15595: update keycloak js for KEYCLOAK-15595#8011sanket-bhalerao wants to merge 1 commit intokeycloak:masterfrom sanket-bhalerao:master
Conversation
mhajas
left a comment
There was a problem hiding this comment.
I tested this on Android and it seems it didn't break anything. Let's wait for ios review, but from my point of view, this looks good.
|
@mhajas any luck? |
|
@mhajas who is supposed to review the iOS part? |
|
@abstractj. I asked @vmuzikar yesterday and he told me he will try to have a look this week. |
vmuzikar
left a comment
There was a problem hiding this comment.
@sanket-bhalerao Thank you for your contribution and sorry for the late reply.
I can confirm this PR correctly fixes the issue. Tested it both on iOS simulator and a real iOS device. BTW, the issue was now reproducible even on the simulator (not just the real device like before).
|
Thank you very much @vmuzikar! @abstractj Could you please run github actions workflow and then possibly merge? |
|
@abstractj @mhajas @vmuzikar any luck? |
1 similar comment
|
@abstractj @mhajas @vmuzikar any luck? |
|
GH has not allowed running the checks, thus closing and reopening. |
|
@abstractj I don't think this PR is causing any failures in Github actions as the code that is changed is not tested. Should we rebase to make the tests pass? |
|
@mhajas we have 2 options:
It is not possible for me to only rebase. |
|
@abstractj @mhajas i have used fetch and merge option in the repository today. it included around 219 commits to my fork. |
|
@sanket-bhalerao Thank you for updating the branch. Unfortunately, the fetch and merge functionality on Github doesn't work as we would like. We prefer having PRs with only one commit so this merge commit shouldn't be there. Could you please squash your commits together so that there is only one? |
|
@mhajas i am not able to squash the commits, please let me know if i should create a new pull request ? |
|
You should be able to do it locally, just run then you need to do force push |
|
@mhajas let me try.. |
|
@mhajas i think something is wrong with it now.. |
|
Ahhh, I am really sorry. That is my fault, it wasn't the best idea to do it. I can open a PR for you or if you want to send it yourself you can close this one and send a new PR based on the latest master. It is also possible to force push it to this branch but should be easier to send a new PR. |
|
let me open a new PR.. |
while working on cordova+angular+ios the keycloak logout is not working. as the user clicks logout the user can again see the app instead of the inappbrowser page for login.
with clearcache=yes in the inappbrowser open the issue appears no more.