Skip to content

KEYCLOAK-19595 ORCID Social Identity Provider#8618

Closed
cgeorgilakis wants to merge 1 commit intokeycloak:mainfrom
eosc-kc:126-orcid
Closed

KEYCLOAK-19595 ORCID Social Identity Provider#8618
cgeorgilakis wants to merge 1 commit intokeycloak:mainfrom
eosc-kc:126-orcid

Conversation

@cgeorgilakis
Copy link
Copy Markdown
Contributor

Copy link
Copy Markdown
Contributor

@stianst stianst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, but not sure we should add this directly to Keycloak. Have you reached out to ORCID folks in regards to the limitation with their OIDC support? That can perfectly well be solved in a standard way with scopes. If that's not successful I think it would be better to package this up as a community maintained extension (https://www.keycloak.org/extensions.html). FIY we do plan to extend on extensions to build more of a "marketplace" of such, and perhaps also having options to discover/install these directly from the Keycloak.X distribution.

@cgeorgilakis
Copy link
Copy Markdown
Contributor Author

We have communicated with ORCID team. Although they want to support the release of email, they could not give us a plan for doing it. Moreover, OIDC implementation does not release other useful User attributes and is not the official implementation. That's why we believe Keycloak should support ORCID as social Identity Provider.
Although, we could implement it as extension, we believe that the best solution is to be in Keycloak core due to maintanance reason ( OrcidIdentityProvider extend AbstractOAuth2IdentityProvider, mapper, ui etc) and we could not implement test like SocialLoginTest in extension.

@stianst
Copy link
Copy Markdown
Contributor

stianst commented Oct 25, 2021

Actually I think it'll be worse if this is integrated as the core Keycloak team doesn't know anything about ORCID, so the integration would pretty much be unmaintained from the point it is merged. That is of course unless you monitor issues reported against Keycloak to see if there's an issues with the integration, which I doubt you could do in an efficient way.

Rather than integrate this into the main code-base I'd look at ways we can do better with extensions, to allow fully community maintained additions.

@cgeorgilakis
Copy link
Copy Markdown
Contributor Author

It would be no problem for us to monitor any issues related to the integration of ORCID with Keycloak. This is something that we will in case have to do since ORCID is required for all our Keycloak deployments. You see ORCID is one of the most popular authentication options for research & education scenarios, including access to the European Open Science Cloud (EOSC). But having ORCID as a core social plugin would simplify things since we can then make use of the SocialLoginTest to identify issues if there are breaking changes.

@stianst
Copy link
Copy Markdown
Contributor

stianst commented Nov 10, 2021

I'm going to close this as mentioned we can't really support or maintain this capability at this point. Please provide an extension for this provider, list it on the website, and open a discussion around how we can provide a better approach when it is maintained as an extension.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants