Skip to content

Add JAVA_OPTS_APPEND option from legacy to X (resolves #9188)#9189

Merged
pedroigor merged 1 commit intokeycloak:mainfrom
dasniko:#9188_java_opts_append
Dec 17, 2021
Merged

Add JAVA_OPTS_APPEND option from legacy to X (resolves #9188)#9189
pedroigor merged 1 commit intokeycloak:mainfrom
dasniko:#9188_java_opts_append

Conversation

@dasniko
Copy link
Copy Markdown
Contributor

@dasniko dasniko commented Dec 16, 2021

This adds the option to add additional, custom JAVA_OPTS to the server startup scripts, without the need to overwrite the complete defaults.

resolves #9188

Copy link
Copy Markdown
Contributor

@DGuhr DGuhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the typos, lgtm. Thanks for the contribution! Would be great if you could fix the typos, so we get this in :)

Comment thread distribution/server-x-dist/src/main/content/bin/kc.bat Outdated
Comment thread distribution/server-x-dist/src/main/content/bin/kc.sh Outdated
@dasniko dasniko force-pushed the #9188_java_opts_append branch from 1a1af2c to fa32cf3 Compare December 16, 2021 16:03
Copy link
Copy Markdown
Contributor

@DGuhr DGuhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now, thanks!

@pedroigor pedroigor merged commit b032694 into keycloak:main Dec 17, 2021
@dasniko dasniko deleted the #9188_java_opts_append branch December 17, 2021 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Provide an option like JAVA_OPTS_APPEND also for Quarkus based Keycloak.X container.

4 participants