Skip to content

Update xmlsec in parent pom#9281

Merged
stianst merged 1 commit intomainfrom
stianst-patch-8
Dec 22, 2021
Merged

Update xmlsec in parent pom#9281
stianst merged 1 commit intomainfrom
stianst-patch-8

Conversation

@stianst
Copy link
Copy Markdown
Contributor

@stianst stianst commented Dec 21, 2021

Bumping this to align with WildFly 26 as the current version contains vulnerabilities.

@stianst stianst requested a review from hmlnarik December 21, 2021 12:10
@stianst stianst mentioned this pull request Dec 21, 2021
Closed
DGuhr
DGuhr reviewed Dec 21, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@DGuhr DGuhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we also update it here? https://github.com/keycloak/keycloak/blob/main/quarkus/pom.xml#L49 - tbh this was added some weeks before, and I am still not sure we have to actually define the xmlsec version in the quarkus pom when we set it in parent. Quarkus seems not to have an xmlsec dependency (according to https://github.com/quarkusio/quarkus/blob/2.5.4.Final/bom/application/pom.xml at least) so from my understanding it doesn't need to be defined here.

@stianst
Copy link
Copy Markdown
Contributor Author

stianst commented Dec 21, 2021 •
edited
Loading

should we also update it here? https://github.com/keycloak/keycloak/blob/main/quarkus/pom.xml#L49 - tbh this was added some weeks before, and I am still not sure we have to actually define the xmlsec version in the quarkus pom when we set it in parent. Quarkus seems not to have an xmlsec dependency (according to https://github.com/quarkusio/quarkus/blob/2.5.4.Final/bom/application/pom.xml at least) so from my understanding it doesn't need to be defined here.

+1 We should probably just remove that override in there

@DGuhr #9284

@DGuhr DGuhr mentioned this pull request Dec 21, 2021
Merged
@DGuhr
Copy link
Copy Markdown
Contributor

DGuhr commented Dec 21, 2021

@stianst #9285 ;)

@stianst stianst merged commit 5b96bdc into main Dec 22, 2021
@stianst stianst deleted the stianst-patch-8 branch March 15, 2022 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@hmlnarik hmlnarik hmlnarik approved these changes

@DGuhr DGuhr DGuhr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@stianst @DGuhr @hmlnarik