Show error in case of an unkown essential acr claim#9334
Closed
CorneliaLahnsteiner wants to merge 1 commit intokeycloak:mainfrom
Closed
Show error in case of an unkown essential acr claim#9334CorneliaLahnsteiner wants to merge 1 commit intokeycloak:mainfrom
CorneliaLahnsteiner wants to merge 1 commit intokeycloak:mainfrom
Conversation
Contributor
|
@CorneliaLahnsteiner I am closing this PR as I've sent another PR #10088 , which includes your tests together with the fixes to make sure that tests are passing. Note that I've found another issue (mentioned in the "Related issue" section of #8724 ), which I've also fixed in this PR. Review and feedback of the new PR is welcome! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just related to the Step up Authentication:
Currently only tests are commited, which are failing due to the code. @mposolda wanted to have a look at it, after the step up authentication is merged.
Closes #8724