JPA map storage: Client scope no-downtime store#9746
Merged
hmlnarik merged 1 commit intokeycloak:mainfrom Feb 1, 2022
Merged
Conversation
ahus1
previously approved these changes
Jan 24, 2022
Member
ahus1
left a comment
There was a problem hiding this comment.
LGTM. I reviewed the code and started it locally. Client scopes were filled, and I could edit a client scope. Thanks!
383cdce to
45e6356
Compare
ahus1
previously approved these changes
Jan 26, 2022
hmlnarik
reviewed
Jan 26, 2022
2e75a55 to
62382bf
Compare
hmlnarik
suggested changes
Jan 28, 2022
62382bf to
b320888
Compare
hmlnarik
reviewed
Jan 28, 2022
sguilhen
suggested changes
Jan 28, 2022
b320888 to
c6812e7
Compare
47edf35 to
4975cc3
Compare
ahus1
reviewed
Feb 1, 2022
ahus1
requested changes
Feb 1, 2022
Member
ahus1
left a comment
There was a problem hiding this comment.
Tested the code locally and found that keycloak didn't start up as the selected columns didn't match the constructors for the recently added "version" column. The version column is required to identify optimistic locking issues during lazy loading and was introduced in #9645
48d3d49 to
aaf846b
Compare
ahus1
requested changes
Feb 1, 2022
Member
ahus1
left a comment
There was a problem hiding this comment.
I reviewed the changes and tested them locally. Local test was successful.
One open review comment remains on Integer vs. int on the method signature of JpaClientScopeEntity
aaf846b to
0dd3e0a
Compare
Contributor
Thanks for spotting this, indeed, this needs to be consistent with the rest of the codebase. |
ahus1
approved these changes
Feb 1, 2022
Member
ahus1
left a comment
There was a problem hiding this comment.
LGTM - ready to be merged. All previous comments can be resolved (can only be done by PR author or someone with write access to the repository)
hmlnarik
approved these changes
Feb 1, 2022
sguilhen
approved these changes
Feb 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9663