Deprecate built-in Cordova adapters#297
Merged
pskopek merged 1 commit intokeycloak:mainfrom Apr 23, 2026
Merged
Conversation
d145089 to
050c03f
Compare
Contributor
|
It looks good! The release notes text is sufficient as well. |
050c03f to
098a2a6
Compare
Add a deprecation utility (`logDeprecation`) that emits each warning at most once per page load, keyed by a unique code (KC-DEP-###). Use it to deprecate the built-in 'cordova' and 'cordova-native' adapters at runtime, and mark them as deprecated in the type definitions and documentation ahead of removal in the next major. Closes keycloak#271 Signed-off-by: Jon Koops <[email protected]>
098a2a6 to
c9c5a22
Compare
Contributor
Author
|
@rmartinc Done! |
pskopek
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a shared deprecation utility and uses it to deprecate the built-in Cordova adapters ahead of their removal in the next major version.
A new internal module (
lib/deprecations.js) provides alogDeprecation(code, message)function inspired by the Node.js deprecation system. Each deprecation is identified by a unique code (KC-DEP-###) and is emitted at most once per page load to avoid spamming the console.The
cordovaandcordova-nativeadapters now emit runtime deprecation warnings (KC-DEP-001andKC-DEP-002respectively) when loaded, and the corresponding type definitions andcordovaOptionsproperty are marked as deprecated. Release notes for 26.3.0 document the deprecation and provide a migration path to custom adapters.Closes #271