Skip to content

Added instructions and support for have script policy provider workin…#316

Merged
mposolda merged 1 commit intokeycloak:mainfrom
mposolda:9945-java17-nashorn
May 27, 2022
Merged

Added instructions and support for have script policy provider workin…#316
mposolda merged 1 commit intokeycloak:mainfrom
mposolda:9945-java17-nashorn

Conversation

@mposolda
Copy link
Copy Markdown
Contributor

…g on Java 17

@mposolda
Copy link
Copy Markdown
Contributor Author

This is draft PR related to keycloak/keycloak#11322 . See that PR for more details.

Comment thread authz-js-policies/README.md Outdated
System Requirements
-------------------

You need to have Keycloak 18.0.Final running.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps better "at least Keycloak 18.0.Final" or sth? I'd avoid strict version pinning in a general example.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, true. Thanks for these points. I've copy/pasted this from the README of some other example :-) Similarly the Java version.

It seems that README files of the quickstarts, which are deployable to Keycloak server, may need some revision as they are currently target just for the Keycloak on Wildfly.

This particular quickstart didn't have README file like the other quickstarts have. So I've added README file, but for this README, I've added lots of TODO and I focused only on parts specific to instructions for deployment on Keycloak on Wildfly VS Keycloak on Quarkus as this is the most important part for the particular use-case addressed here for the scripts providers. I can properly update the README file and remove all TODOs if we agree that my approach for script providers work.

@mposolda mposolda force-pushed the 9945-java17-nashorn branch from a9655aa to 362fd59 Compare April 25, 2022 09:20
pedroigor
pedroigor previously approved these changes Apr 25, 2022
@mposolda mposolda force-pushed the 9945-java17-nashorn branch 2 times, most recently from 5735385 to b98eeaf Compare May 23, 2022 17:02
@mposolda mposolda marked this pull request as ready for review May 23, 2022 17:03
@mposolda mposolda linked an issue May 23, 2022 that may be closed by this pull request
@mposolda mposolda force-pushed the 9945-java17-nashorn branch from b98eeaf to e267b11 Compare May 23, 2022 17:52
@mposolda
Copy link
Copy Markdown
Contributor Author

@pedroigor @DGuhr Do you please have a chance to re-review this? Corresponding main codebase PR is also ready for the review: keycloak/keycloak#11322 .
Thanks

@mposolda mposolda merged commit 00224ca into keycloak:main May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

JavaScript Provider quickstarts on Java 17

3 participants