An example about how to enable policy enforcement to Elytron/Jakarta applications#396
Merged
mposolda merged 1 commit intokeycloak:mainfrom Apr 19, 2023
Merged
Conversation
1113cb2 to
ef6b657
Compare
c2283df to
9d81807
Compare
mposolda
requested changes
Apr 14, 2023
Contributor
mposolda
left a comment
There was a problem hiding this comment.
@pedroigor Added few inline comments. Marking this as "request changes" until we figure how to tackle this.
| <scope>compile</scope> | ||
| <groupId>org.keycloak</groupId> | ||
| <artifactId>keycloak-admin-client-jakarta</artifactId> | ||
| <version>21.0.2</version> |
Contributor
There was a problem hiding this comment.
I guess the hardcoded version here should be avoided?
Is it possible to use <version>${version.keycloak}</version> ? Or ideally avoid <version> element entirely and make sure that correct version is just taken from the parent pom (keycloak BOM) as I've mentioned in the other comments to this file?
2a20ad5 to
ad120ae
Compare
Contributor
Author
|
@mposolda About the I'll see why. |
ad120ae to
6ce70ac
Compare
mposolda
requested changes
Apr 17, 2023
Contributor
mposolda
left a comment
There was a problem hiding this comment.
@pedroigor Still few inline questions added
6ce70ac to
1865901
Compare
Contributor
Author
|
Hope is fine now. |
1865901 to
a30d72a
Compare
…applications Closes #keycloak#19540
a30d72a to
895de6b
Compare
mposolda
approved these changes
Apr 19, 2023
Contributor
mposolda
left a comment
There was a problem hiding this comment.
@pedroigor Thanks for the updates!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
app-authz-jee-servletquickstart to Jakartajakartaprofile to allow running integration tests using Wildfly