Migrated following keycloak-quickstart extension tests using new keyc… by jimmychakkalakal · Pull Request #741 · keycloak/keycloak-quickstarts

jimmychakkalakal · 2026-04-13T10:39:35Z

Migrated following keycloak-quickstart extension tests using new keycloak testframework:

Tests under extension/action-token-authenticator and extension/action-token-required-action

Closes #739

…loak testframework: Tests under extension/action-token-authenticator and extension/action-token-required-action Closes keycloak#739 Signed-off-by: Jimmy Chakkalakal <[email protected]>

mposolda

@jimmychakkalakal Thanks for the PR!

The idea looks good.

I think test failures in node.js and javascript tests in GH actions are not related to your PR and hence are out of scope.

It is unfortuate that action-token quickstarts still need Wildfly AFAIK and hence I guess that is the reason why arquillian+wildfly still needs to be used in the action-token quickstart?

It will be ideal if we can get rid of the arquillian in the action-token quickstarts. That will probably require those action-token quickstarts to not use Wildfly. Which we can hopefully do (either by deploying custom REST endpoint provider to Keycloak, or by using quarkus instead of Wildfly). But I suppose that might be a follow-up of this task. As initial PR, this is OK to me.

@lhanusov Do you please have opportunity to review?

jimmychakkalakal · 2026-04-16T10:32:44Z

It is unfortuate that action-token quickstarts still need Wildfly AFAIK and hence I guess that is the reason why arquillian+wildfly still needs to be used in the action-token quickstart? --> Yes,

lhanusov · 2026-04-16T12:51:57Z

Hi Marek and Jimmy, @mposolda @jimmychakkalakal, did you consider using testcontainers: https://java.testcontainers.org/features/creating_container/ for using wildfly?

abstractj · 2026-04-16T13:19:00Z

@lhanusov honestly I don't see a reason for us to invest any more time on quickstarts with WildFly. Ideally we should plan the migration to Quarkus.

lhanusov

Thank you for taking care of it Jimmy. To correlate with the new test framework, few changes must be done, before merging it. Please, let me know if you need any help with it. Thanks

lhanusov · 2026-04-16T12:57:19Z

+    static ManagedRealm realm;

    @Drone
    private WebDriver webDriver;


Please, don't use Drone from Arquillian, but InjectWebDriver and ManagedWebDriver from the test framework.

lhanusov · 2026-04-16T12:58:18Z

+    private static boolean userCreated = false;

    @Deployment(testable=false, name=EXTERNAL_APP)
    @TargetsContainer("wildfly")


I propose to use testcontainers lib instead: https://java.testcontainers.org/features/creating_container/

lhanusov · 2026-04-16T13:00:08Z

-
-    @Before
+    @BeforeEach
    public void setup() {


I don't think this is actually needed, since it's handled by the framework itself. Please, remove the whole method.

lhanusov · 2026-04-16T13:01:16Z

+        oAuthClient.openLoginForm();
+
+        // Attempt to login as alice using WebDriver directly
+        webDriver.findElement(org.openqa.selenium.By.id("username")).sendKeys("alice");


What is the reason to use the WebDriver directly instead of the LoginPage?

lhanusov · 2026-04-16T13:04:35Z

+        }
+    }
+
+    private void createUserIfNeeded() {


Why don't you use ManagedUser instead? ManagedUser has Class lifecycle, that means it's created once.

lhanusov · 2026-04-16T13:37:16Z

-@RunWith(Arquillian.class)
+@ExtendWith(ArquillianExtension.class)
+@KeycloakIntegrationTest(config = ArquillianActionTokenTest.ServerConfig.class)
 public class ArquillianActionTokenTest {


please, rename it to ActionTokenTest

lhanusov · 2026-04-16T13:37:57Z

-    }
-
-    @Before
+    @BeforeEach


same applies over here, as in the previous test class, this method can be removed

lhanusov · 2026-04-16T13:38:58Z

+    private void createUserIfNeeded() {
+        if (userCreated) {
+            return;
+        }
+
+        UserRepresentation alice = new UserRepresentation();
+        alice.setUsername("alice");
+        alice.setEmail("[email protected]");
+        alice.setFirstName("Alice");
+        alice.setLastName("Liddel");
+        alice.setEnabled(true);
+
+        CredentialRepresentation credential = new CredentialRepresentation();
+        credential.setType(CredentialRepresentation.PASSWORD);
+        credential.setValue("password");
+        credential.setTemporary(false);
+        alice.setCredentials(List.of(credential));
+
+        jakarta.ws.rs.core.Response response = realm.admin().users().create(alice);
+        response.close();
+
+        userCreated = true;
+    }
+
+    private void setupRequiredActionIfNeeded() {
+        if (requiredActionConfigured) {
+            return;
+        }
+
+        // Register the custom required action provider
+        RequiredActionProviderSimpleRepresentation requiredActionProvider = new RequiredActionProviderSimpleRepresentation();
+        requiredActionProvider.setProviderId("redirect-to-external-application");
+        requiredActionProvider.setName("Redirect to external application");
+        realm.admin().flows().registerRequiredAction(requiredActionProvider);
+
+        // Add the new required action to alice user
+        List<String> reqActions = Arrays.asList("redirect-to-external-application");
+        realm.admin().users().search("alice").forEach(u -> {
+            u.setRequiredActions(reqActions);
+            realm.admin().users().get(u.getId()).update(u);
+        });
+
+        // Enable unmanaged attributes of user profile
+        UserProfileResource userProfileRes = realm.admin().users().userProfile();
+        UPConfig cfg = userProfileRes.getConfiguration();
+        cfg.setUnmanagedAttributePolicy(UPConfig.UnmanagedAttributePolicy.ENABLED);
+        userProfileRes.update(cfg);
+
+        requiredActionConfigured = true;
+    }


please move it to the RealmConfig

lhanusov · 2026-04-16T13:40:16Z

+    static ManagedRealm realm;

    @Drone
    private WebDriver webDriver;


please, replace it with InjectWebDriver and ManagedWebDriver

lhanusov · 2026-04-16T13:40:42Z

+    private static boolean userCreated = false;

    @Deployment(testable=false, name=EXTERNAL_APP)
    @TargetsContainer("wildfly")


please consider for replacing it with testcontainers

Migrated following keycloak-quickstart extension tests using new keyc…

7d1731a

…loak testframework: Tests under extension/action-token-authenticator and extension/action-token-required-action Closes keycloak#739 Signed-off-by: Jimmy Chakkalakal <[email protected]>

jimmychakkalakal requested a review from mposolda April 13, 2026 10:40

mposolda self-assigned this Apr 16, 2026

mposolda requested a review from lhanusov April 16, 2026 10:18

mposolda reviewed Apr 16, 2026

View reviewed changes

lhanusov suggested changes Apr 16, 2026

View reviewed changes

Conversation

jimmychakkalakal commented Apr 13, 2026

Uh oh!

mposolda left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jimmychakkalakal commented Apr 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lhanusov commented Apr 16, 2026

Uh oh!

abstractj commented Apr 16, 2026

Uh oh!

lhanusov left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

mposolda left a comment •

edited

Loading

jimmychakkalakal commented Apr 16, 2026 •

edited

Loading