Skip to content

Update LoginPassword.tsx to wrap the element correctly#949

Merged
garronej merged 1 commit intokeycloakify:mainfrom
pnzrr:pnzrr-patch-2
Dec 2, 2025
Merged

Update LoginPassword.tsx to wrap the element correctly#949
garronej merged 1 commit intokeycloakify:mainfrom
pnzrr:pnzrr-patch-2

Conversation

@pnzrr
Copy link
Copy Markdown
Contributor

@pnzrr pnzrr commented Oct 31, 2025 •
edited by coderabbitai Bot
Loading

Properly matches: https://github.com/keycloak/keycloak/blob/main/themes/src/main/resources/theme/base/login/login-password.ftl

Summary by CodeRabbit

  • Style
    • Reorganized DOM structure for password reset options on the login page to improve layout consistency.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Oct 31, 2025 •
edited
Loading

Walkthrough

The LoginPassword.tsx file undergoes a DOM restructuring change where the reset-password options container is reorganized. The content is wrapped with a nested div using the kcFormOptionsWrapperClass, moving from a flat structure to a nested one within kc-form-options. No behavioral changes.

Changes

Cohort / File(s) Summary
DOM Structure Reorganization
src/login/pages/LoginPassword.tsx		 Reset-password options moved into nested wrapper div inside kc-form-options container; restructures DOM hierarchy without changing conditional rendering or behavior

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Verify DOM nesting is intentional and doesn't break styling or accessibility
  • Confirm the kcFormOptionsWrapperClass is correctly applied

Poem

🐰 A hop through the DOM, so neat and so fine,
Nested divs wrapped in a structural line,
No logic was changed, just moved all about,
The form options gleam with newfound clout! ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The pull request title "Update LoginPassword.tsx to wrap the element correctly" directly and clearly describes the main change in the changeset. The summary confirms the core modification is a DOM structure reorganization where reset-password options are wrapped inside a new nested div element with className={kcClsx("kcFormOptionsWrapperClass")}. The title is specific to the file being changed, concise, and conveys the primary action (wrapping elements) without ambiguity or vague terminology. A teammate reviewing commit history would quickly understand that this PR involves restructuring DOM elements in the LoginPassword component.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bf1329a and 34f3cd9.

📒 Files selected for processing (1)
  • src/login/pages/LoginPassword.tsx (1 hunks)
🔇 Additional comments (1)
src/login/pages/LoginPassword.tsx (1)

76-86: LGTM! DOM restructuring correctly matches the upstream Keycloak template.

The nested structure places the reset password content inside kc-form-options with the kcFormOptionsWrapperClass wrapper, exactly matching the upstream template at https://github.com/keycloak/keycloak/blob/main/themes/src/main/resources/theme/base/login/login-password.ftl.

Ensure any CSS selectors depending on the DOM structure are updated accordingly to prevent styling issues.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@garronej
Copy link
Copy Markdown
Collaborator

garronej commented Dec 2, 2025

Thank you @pnzrr,

Sorry it slipped through.

@allcontributors add @pnzrr for code

@garronej garronej merged commit 83d04af into keycloakify:main Dec 2, 2025
7 checks passed
@allcontributors allcontributors Bot mentioned this pull request Dec 2, 2025
Merged
@allcontributors
Copy link
Copy Markdown
Contributor

allcontributors Bot commented Dec 2, 2025

@garronej

I've put up a pull request to add @pnzrr! 🎉

garronej added a commit to keycloakify/login-ui that referenced this pull request Dec 2, 2025
@garronej
https://github.com/keycloakify/keycloakify/pull/949
19bf755
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pnzrr @garronej